Repository navigation
fix(web): image chips drop the pill and match other chips - #26379
Conversation
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Image chips lose their pill border, background and extra padding while retaining their accent color and existing interactions. The change is limited to presentation, with no material behavioral or data risk. Notes:
You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update image variant styles apps/web/src/components/ContextChip.tsx |
The image variant removes rounded corners, a border, a tinted background, and horizontal padding. It retains the image accent-color declaration. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Suggested reviewers: yash-singh1
Merge Risk: 
b0890
-
The image chip styling change is ready to merge.
Pre-merge checks: 
-
Check name Status Explanation Title check The title "fix(web): image chips drop the pill and match other chips" follows conventional commit format and names the primary change: removing the pill styling from the web image chip variant. The ra… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Description check The description follows the template's main sections (Problem, Change, Scope and approval, Verification) and explains the cause: #26306added a rounded, tinted pill to the web image chip, which made i…Full details: Title check
-
Explanation
The title "fix(web): image chips drop the pill and match other chips" follows conventional commit format and names the primary change: removing the pill styling from the web image chip variant. The raw summary confirms the ContextChip.tsx image variant no longer applies rounded corners, border, tinted background, or horizontal padding, and the PR objectives match this change. The title is specific and clear.
Full details: Description check
-
Explanation
The description follows the template's main sections (Problem, Change, Scope and approval, Verification) and explains the cause:
#26306added a rounded, tinted pill to the web image chip, which made it the only boxed chip. The change removes that pill and keeps the blue accent, and mobile is unaffected. The scope section justifies skipping a prior issue as a one-line follow-up that only removes the pill added by the merged#26306. Verification reports that check:changed passes and that the dark theme was captured in the composer and a sent message with before/after images. Gaps: the light theme and an adjacent file chip were not captured, and the description does not say how the screenshots were used to verify behavior beyond the dark theme. The template also asks for the agent model and harness, which the author supplied. The description is mostly complete.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
## What's Changed * docs(agents): agents verify in a browser or simulator without asking by @juliusmarminge in pingdotgg/t3code#26637 * feat(pull-requests): manage GitHub maintainer edits by @Bil0000 in pingdotgg/t3code#25588 * fix(web): image chips drop the pill and match other chips by @flamboh in pingdotgg/t3code#26379 * fix(mobile): align settled and active thread rows by @PixPMusic in pingdotgg/t3code#26622 * fix(server): publish local git status before remote lookup by @JustYannicc in pingdotgg/t3code#21046 * fix(server): outside MCP clients get thread links they can open by @t3dotgg in pingdotgg/t3code#26642 * fix(web): double-click selects the whole inline code span by @t3dotgg in pingdotgg/t3code#26639 * fix(acp): ID-only command approvals keep the tracked command and grant the terminal by @juliusmarminge in pingdotgg/t3code#26647 * fix(cursor): subagent ls, lint and MCP results no longer fail the parent run by @juliusmarminge in pingdotgg/t3code#26592 * perf(web): long-thread timeline rebuilds 45 → 9 ms, tool updates 12 → 0.3 ms by @juliusmarminge in pingdotgg/t3code#26727 * fix(mobile): a thread opened while reconnecting no longer turns into a new draft by @shivamhwp in pingdotgg/t3code#26565 * fix(web): keep settled drop hint inside the sidebar viewport by @Yash-Singh1 in pingdotgg/t3code#26736 * feat(devices): Simlock setup uses each machine's agent-device token, checks tokens, and lists the pool through worker reconnects by @juliusmarminge in pingdotgg/t3code#26706 * fix(web): pull request diff follows the file tree, with a hide-tests filter by @juliusmarminge in pingdotgg/t3code#26730 * fix(mobile): delivered messages no longer reappear at the bottom of long threads by @juliusmarminge in pingdotgg/t3code#26739 * ci(mobile): fork PRs now get the Native Change label by @juliusmarminge in pingdotgg/t3code#26755 * fix(claude): command approvals show the command, not Claude's description of it by @maria-rcks in pingdotgg/t3code#20145 * docs: add nixpkgs installation instructions by @0x4bs3nt in pingdotgg/t3code#26750 * feat(server,web,mobile): fall back when the default provider is out of usage by @maria-rcks in pingdotgg/t3code#26164 * fix(ci): fork PRs now resolve in workflow_run PR lookups by @juliusmarminge in pingdotgg/t3code#26779 **Full Changelog**: pingdotgg/t3code@v0.1.4-nightly.20261028.3841...v0.1.4-nightly.20261029.3853 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.4-nightly.20261029.3853
Note
🤖 Claude Opus 5.5 on behalf of Oliver
Problem
#26306 fixed image attachment chips that showed up in error red. It also gave them a rounded, tinted pill that no other chip kind has. That made image chips the only boxed chip in the composer and in sent messages.
Change
This removes the pill from the web
imagechip variant and keeps #26306's blue accent. Image chips are colored text with an icon again, like every other chip. Mobile never got the pill, so it doesn't change.Scope and approval
This is a one-line visual follow-up to the merged #26306, so there's no separate issue. It removes only the pill that PR added and keeps its color fix.
Verification
vp run check:changedpasses.mainvs this branch), in the composer and in a sent message. Light theme and an adjacent file chip weren't captured.Made with Claude Opus 5.5 in Claude Code (T3 Code). Screenshots captured by GPT-6.1 Sol in Codex.