[juliusmarminge]

Enforce effectFnOpportunity as an error and make reusable Effect-returning functions use explicit function boundaries.

Named Effect.fn remains the default, including synchronous operations and service stubs. Existing span names move into the function wrapper; settings retain argument-derived span attributes. Hot paths, protocol loops, inline match/error handlers, and forwarders over already traced operations use generator-based Effect.fnUntraced. The relay HTTP authorization span stays inside its tracer override. Provider span names identify their implementation rather than a generic interface.

The conversion preserves lazy execution and existing error/cancellation behavior. Statements before a returned Effect now execute with the function's Effect; the runtime-command callers execute that Effect directly. This is a single-rule change rebased onto current main, without the earlier stack's commits.

Validation:

• vp run check:changed origin/main: formatting, lint, Knip, GraphQL generation, 34 affected typechecks, and 1,871 tests across 96 files passed.
• A tracing regression test verifies exactly one window-bounds operation span, with its input attributes and completed status.
• Opus 5.5 and Fable 5.1 independently reviewed the revision. Their remaining duplicate forwarding wrappers were converted to untraced generators and checked separately.

Model: GPT-6.1 Sol, Codex harness. Advisory reviews: Claude Opus 5.5 and Claude Fable 5.1.

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	5.0 KiB	5.0 KiB	+7 B (+0.1%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	+7 B (+0.6%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	20.9 KiB	20.9 KiB	0 B (0.0%)	29.3 KiB	✅
Codex	Live turn messages	2	2	0 (0.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.2 KiB	1.2 KiB	0 B (0.0%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.2 KiB	21.2 KiB	0 B (0.0%)	29.3 KiB	✅
Claude	Live turn messages	2	2	0 (0.0%)	8	✅

Baseline: d171a88 · PR result: 98adf3d · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This is a 138-file cross-cutting Effect tracing and lint-enforcement refactor that changes observability and execution wrappers across production paths, including authentication code. The authentication-path changes and remaining tracing-boundary concerns require targeted human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[macroscopeapp]

Both operations already have explicit environment.authorization* spans, so these named wrappers add redundant spans around the existing tracing boundaries. Please keep the existing span names/options and use unnamed Effect.fn wrappers for both operations.

Suggested change

	authorizeDpop: Effect.fn("RemoteEnvironmentAuthorization.authorizeDpop")(function (input) {
	authorizeDpop: Effect.fn(function (input) {

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

These production WSL operations already use explicit desktop.wsl.* spans. The named wrappers add a second operation span to preWarm, prepareRuntime, pruneRuntimes, invalidateRuntime, probeRuntime, and ensureNodePty. Please keep the existing span names and use unnamed wrappers for these operations.

Suggested change

	preWarm: Effect.fn("DesktopWslEnvironment.preWarm")(function (distro) {
	preWarm: Effect.fn(function (distro) {

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

getDescriptor already uses Effect.withSpan("EnvironmentAuth.getDescriptor"); this named wrapper creates a second span with the same name. Please use an unnamed wrapper to retain the existing single tracing boundary.

Suggested change

	getDescriptor: Effect.fn("EnvironmentAuth.getDescriptor")(function () {
	getDescriptor: Effect.fn(function () {

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

getDescriptor already has a withSpan with this exact name. The named Effect.fn adds an identical outer span; please use the unnamed wrapper and preserve the existing span.

Suggested change

	getDescriptor: Effect.fn("EnvironmentAuthPolicy.getDescriptor")(function () {
	getDescriptor: Effect.fn(function () {

^{Posted via Macroscope — Effect Service Conventions}

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

• Last reviewed commit: 98adf3d

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: lint-rules/effectFnOpportunity
• File: .coderabbit.config.ts
• Commit: 98adf3d
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 303469b4-f0e0-47c6-9642-6b4a1eb8cb51

Commits

Reviewing files that changed from the base of the PR and between 471cf27 and 98adf3d.

Files selected for processing: 3

• apps/server/src/provider/ProviderHostLive.ts
• packages/client-runtime/src/connection/onboarding.ts
• packages/client-runtime/src/state/pullRequestDiffHttp.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

Walkthrough

This pull request migrates Effect callbacks across desktop, server, client, provider, source-control, and infrastructure code to named or untraced Effect functions. It also updates selected handler logic, adds a tracing test, and raises the related TypeScript diagnostic severity.

Changes: Effect function migration

Layer / File(s)	Summary
Desktop services and settings apps/desktop/src/app/*, apps/desktop/src/backend/*, apps/desktop/src/electron/*, apps/desktop/src/settings/*, apps/desktop/src/snapShot/*, apps/desktop/src/ssh/*, apps/desktop/src/updates/*, apps/desktop/src/wsl/*	Desktop operations now use named or untraced Effect wrappers. Production settings setters annotate spans with input attributes. A test checks the main-window-bounds span and its attributes.
Server services and request handlers apps/server/scripts/*, apps/server/src/auth/*, apps/server/src/cloud/*, apps/server/src/device/*, apps/server/src/environment/*, apps/server/src/git/*, apps/server/src/htmlRender/*, apps/server/src/mcp/*	Callbacks use Effect wrappers. The orchestration executor also uses Effect.catchIf for a specific interrupt-failure condition.
Orchestration services and state apps/server/src/orchestration-v2/*	Orchestration services, stores, adapters, and test helpers use Effect wrappers. The private daemon layer and provider-adapter layer are removed.
Server data, provider, and preview operations apps/server/src/persistence/*, apps/server/src/preview/*, apps/server/src/process/*, apps/server/src/project/*, apps/server/src/provider/*, apps/server/src/pullRequest/*, apps/server/src/relay/*, apps/server/src/resourceTelemetry/*, apps/server/src/sourceControl/*, apps/server/src/telemetry/*, apps/server/src/textGeneration/*, apps/server/src/vcs/*	Service and callback implementations use named or untraced Effect wrappers. Existing storage, forwarding, and preview behavior is retained.
Client runtime and protocol operations apps/web/src/connection/*, packages/client-runtime/src/*, packages/effect-acp/src/*, packages/effect-codex-app-server/src/*	Client state, connection, authorization, web storage, and protocol callbacks use Effect wrappers. Handler-registration and message-processing behavior remain unchanged.
Provider services and adapters packages/provider-acp-registry/src/*, packages/provider-acp/src/*, packages/provider-core/src/*, packages/provider-cursor/src/*, packages/provider-muse/src/*, packages/provider-opencode/src/*, packages/provider-pi/src/*, packages/provider-testing/src/*	Provider services and adapter operations use Effect wrappers. Their described capability results, delegation, and provider-session behavior remain unchanged.
Source-control provider operations packages/source-control-azure-devops/src/*, packages/source-control-bitbucket/src/*, packages/source-control-forgejo/src/*, packages/source-control-gitcafe/src/*, packages/source-control-github/src/*, packages/source-control-gitlab/src/*	Provider operations use named Effect wrappers. Bitbucket revision-cache keys now use a schema-based encoder.
Infrastructure and shared utilities infra/relay/src/*, infra/task-cache/src/*, packages/shared/src/*, packages/ssh/src/*, tsconfig.base.json	Infrastructure and shared callbacks use Effect wrappers. The base configuration changes the Effect function diagnostic severity from suggestion to error.

Priority: Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Refactor

Suggested reviewers: maria-rcks, t3dotgg

Merge Risk: Minimal · up to 98adf

The reviewed forwarding changes have no identified merge-blocking issue; proceed with normal checks.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly identifies the primary change: enforcing the effectFnOpportunity lint rule.
Description check		The description explains the problem, implementation, scope, tracing behavior, and focused validation results. It is complete enough for review, although it does not explicitly link a triaged issue or…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the problem, implementation, scope, tracing behavior, and focused validation results. It is complete enough for review, although it does not explicitly link a triaged issue or maintainer approval.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}