[t3dotgg]

When Kotlin sources exist and ktlint or detekt is not installed, lint:mobile only printed a warning and exited 0. A local run looked green without checking any Kotlin.

Takeover of #7682 by @shubhxho. Their commit is kept with its authorship. I rebased it onto main, switched the new error to Schema.TaggedError (main no longer exports Schema.TaggedErrorClass), and kept only the new tests, which check the error tag and the missing commands. Main deleted the old test file in #22557.

With this change, a missing ktlint or detekt fails the check with NativeStaticCheckMissingToolError that names the missing tools and keeps the Brewfile install hint. SwiftLint stays optional, so Linux and Windows checkouts can still lint without Swift tools. CI installs the Brewfile tools, so CI behavior does not change.

Proof: scripts/mobile-native-static-check.test.ts fails against the main version of the script (requireKotlinTools is not a function) and passes here. Ran vp test run scripts/mobile-native-static-check.test.ts and vp run check:changed (format, lint, knip, typecheck, test all pass). I did not run lint:mobile itself on a machine with and without the JVM tools. The issue reporter verified the original branch locally.

Closes #7625

Made by Claude Opus 5.5 in Claude Code, running in T3 Code.
🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 34b845c

Macroscope's review found this PR approvable — This is a focused tooling fix: Kotlin static checks now fail explicitly when ktlint or detekt is unavailable instead of silently passing, while successful checks and optional SwiftLint behavior remain unchanged. The added tests cover the new missing-tool cases, and no product runtime path is changed.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: d47bf16c-ea0f-4346-a510-1ccd1c141584

📥 Commits

Reviewing files that changed from the base of the PR and between e822ba7 and 34b845c.

📒 Files selected for processing: 2

• scripts/mobile-native-static-check.test.ts
• scripts/mobile-native-static-check.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

📝 Walkthrough

When Kotlin sources exist, the mobile static check now requires both ktlint and detekt. It reports missing tools instead of skipping Kotlin analysis. SwiftLint remains skippable when unavailable.

Changes: Kotlin tool enforcement

Layer / File(s)	Summary
Kotlin tool validation scripts/mobile-native-static-check.ts, scripts/mobile-native-static-check.test.ts	Adds a public error and validation function for missing Kotlin tools. Tests cover success when both tools are available and errors that list missing tools.
Enforce tools during Kotlin analysis scripts/mobile-native-static-check.ts	Requires both tools before running Kotlin analysis. Updates the command description to document this requirement and that SwiftLint may be skipped.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 34b84

When Kotlin sources exist, missing Kotlin tools cause lint:mobile to fail clearly. No merge-blocking issue remains after normal checks.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the primary change: mobile lint now fails when required Kotlin tools are missing.
Description check		The description explains the problem, the implementation, affected tools, issue reference, verification commands, and untested scenarios. It does not use the template headings and does not provide an …
Linked Issues check		Issue [#7625] requires Kotlin checks to run when possible or fail clearly when ktlint or detekt is missing. The change checks both tools when Kotlin sources exist, returns `NativeStaticCheckMissin…
Out of Scope Changes check		The changed source and test file support issue [#7625]. The source change enforces Kotlin tool availability and documents the behavior. The tests verify the new error and missing-command lists. No unr…

Full details: Description check

Explanation

The description explains the problem, the implementation, affected tools, issue reference, verification commands, and untested scenarios. It does not use the template headings and does not provide an explicit maintainer approval comment, but it is otherwise sufficiently complete and focused.

Full details: Linked Issues check

Explanation

Issue [#7625] requires Kotlin checks to run when possible or fail clearly when ktlint or detekt is missing. The change checks both tools when Kotlin sources exist, returns NativeStaticCheckMissingToolError with the missing command names, and runs both Kotlin analyzers only after the check passes. The error retains the Brewfile installation hint and mentions JVM tools on PATH. SwiftLint remains optional. The new tests cover both available tools, each individual missing tool, and both tools missing.

Full details: Out of Scope Changes check

Explanation

The changed source and test file support issue [#7625]. The source change enforces Kotlin tool availability and documents the behavior. The tests verify the new error and missing-command lists. No unrelated change is shown in the pull request diff.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}