[shrikantkalar023]

Bare repositories currently return no repository identity because Git's work-tree-root query fails. Their projects therefore stay separate from checkouts of the same remote.

After a completed root-query failure, probe the project directory and its .git target explicitly, accepting only a bare repository. Read its remotes with an explicit Git directory, preserve safe.bareRepository=explicit, and use the Git directory as rootPath. Normal checkout discovery, shared caching and refresh remain intact; checkout metadata directories and repositories without a usable remote return no identity. Failed or timed-out process launches stop discovery.

Rebuilt on current main from @shrikantkalar023's original contribution, retaining the contributor's commits. The original five added tests were reduced to four behavior cases; the resolver suite is 16 tests instead of 17.

Verification at 2e0a27b9c1:

• Resolver and enrichment suites: 23 passed / 2 expected bare-layout failures before → 25 passed after.
• Server and contracts typechecks, focused lint, formatting and diff checks passed. Four temporary mutations were caught; alias cache hits and cross-path refresh were checked.
• Real Linux Git → actual server resolver → shared client grouping: plain bare, .bare and pointer-container projects in separate synthetic environments produce two groups before → one after, in both repository grouping modes. Checkout .git metadata remains rejected.
• One independent full-diff review round by Claude Opus 5.5 and Codex GPT-6 Sol found no code blockers.

Before/after test and grouping proof

This is identity/grouping behavior, with no visual layout change. No browser session or live multi-machine client session was run. Windows/macOS Git path handling, Electron desktop, iOS/Android and Forgejo refinement were not verified natively on this Linux host. Each uncached non-Git project can now perform up to two additional bounded Git probes; negative caching remains one minute. Current-head build/typecheck, lint, release smoke, general tests and all eight server shards passed; configured correctness and approvability checks passed. CI is blocked: the first web job failed two unchanged browser cases on asynchronous rendering waits; both files passed locally (6/6). The rerun failed the same cases plus an unchanged HtmlRenderDialog zoom-button timeout. No web/client-runtime or workflow source changes are in this PR. These unrelated browser failures were not bypassed; the PR is not declared merge-ready. A canceled duplicate fingerprint run is superseded by the successful fingerprint run on the same head.

Implementation: Codex GPT-6.1 Sol in T3 Code; tests: Codex GPT-6 Astra; adversarial reviews: Claude Opus 5.5 and Codex GPT-6 Sol.

[macroscopeapp]

Approvability

Verdict: Approved at 2e0a27b

Macroscope's review found this PR approvable — This is a narrowly scoped server-side bug fix that adds tested bare-repository detection while preserving normal checkout behavior. The contract change is documentation-only, and the runtime impact is limited to enabling existing repository identity and grouping flows for bare repositories.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Warning

Review limit reached

Only developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing.

Next included review available in 14 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 12097e6d-9b85-4a21-b32c-11a09e649cf5

📥 Commits

Reviewing files that changed from the base of the PR and between c0fe8a6 and f4954f5.

📒 Files selected for processing: 3

• apps/server/src/project/RepositoryIdentityResolver.test.ts
• apps/server/src/project/RepositoryIdentityResolver.ts
• packages/contracts/src/environment.ts

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 20cbfe2e-518e-4da2-84cd-3efd928dc753

📥 Commits

Reviewing files that changed from the base of the PR and between b512235 and c0fe8a6.

📒 Files selected for processing: 2

• apps/server/src/project/RepositoryIdentityResolver.test.ts
• packages/contracts/src/environment.ts

🚧 Files skipped from review as they are similar to previous changes: 1

• packages/contracts/src/environment.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Repository root resolution now recognizes bare repositories after an unsuccessful work-tree lookup. Tests cover bare repository layouts, failure cases, and checkout .git directories.

Changes: Repository identity resolution

Layer / File(s)	Summary
Resolve work-tree and bare-repository roots apps/server/src/project/RepositoryIdentityResolver.ts, packages/contracts/src/environment.ts	The resolver uses a shared Git invocation helper. It returns a nonempty work-tree path on success, and probes for a bare repository after an unsuccessful work-tree lookup. The contract comment describes rootPath for both repository types.
Test repository root resolution apps/server/src/project/RepositoryIdentityResolver.test.ts	Tests cover retries, timeouts and process-start failures, bare clones and dot-bare layouts, checkout .git directories, and bare repositories without remotes.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to c0fe8

Bare repositories can now share an identity with checkouts using the same remote. No actionable merge-blocking risk is established; the change is ready for normal merge checks.

Security architecture risk: 🔵 Low · up to c0fe8

This is a small repository-matching change with no demonstrated new security issue. Some downstream effects of newly recognized bare repositories remain unverified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The newly affected inputs are registered bare repositories whose local Git configuration supplies a remote. Their identities can participate in existing cross-environment repository selection. In the inspected pull-request selection path, matches still produce explicit environmentId, projectId, and workspaceRoot values rather than merging those ownership identifiers.

Trust Boundaries and Controls

• observed — Root discovery passes the supplied directory as a separate Git argument and accepts the fallback only after successful output reporting true and a nonempty Git directory. Ordinary executable dispatch is non-shell; the unchanged Windows batch-file branch uses argument sanitization. This does not turn a remote-derived grouping identity into proof of repository ownership.
• observed — Newly recognized bare identities enter the existing provider-refinement callback, which can resolve provider context. Its wiring is unchanged, but provider-specific host, account, and credential controls were not fully inspected; unchanged wiring alone does not establish unchanged effective exposure.

Resilience and Maintainability Implications

• observed — Existing project enrichment bounds worker concurrency and pending roots, releases pending reservations after resolution, and scopes workers and queues. The fallback adds one probe inside the existing root-cache loader rather than introducing another background worker or persistent reservation.

Pre-merge checks: 4

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly and concisely describes the primary change: grouping bare repositories with projects that use the same remote.
Description check		The pull request description clearly explains the problem, implementation, scope, verification results, limitations, and test status. It does not provide a dedicated Scope and approval section or expl…

Full details: Description check

Explanation

The pull request description clearly explains the problem, implementation, scope, verification results, limitations, and test status. It does not provide a dedicated Scope and approval section or explicit maintainer approval, but it links the originating contribution and gives sufficient context for this focused fix.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[shrikantkalar023]

self review done.

[juliusmarminge]

Taking over this one. I’ll preserve the original commits, merge main, and adapt bare-repository identity discovery around the current metadata fast path, with focused real-Git regression proof and independent reviews.

Dismissing prior approval to re-evaluate 2e0a27b