fix(mobile): improve composer skill contrast - #10397
Open
Doctorthe113 wants to merge 1 commit into
Open
Conversation
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is a focused mobile UI adjustment affecting composer contrast, Android popover rendering, and editor spacing. It also changes the shipped light and dark theme defaults, warranting human review of the resulting product-wide visual behavior. Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small pr to improve contrast/readability on android app.
For example when in t3code (og) theme's dark mode, inline skill highlight is hard to read because it uses a light magenta color instead of high contrast dark color. Also glass surface doesnt really work well on android. It renders a translucent on the skill/command selector instead of a blurred surface. Resulting poor readability.
==== AI SLOP BELOW =====
Summary
Scope is limited to the Android/mobile composer UI.
Before

After
