Skip to content

fix(mobile): restore Android composer skill pills - #11060

Closed
sameerr03 wants to merge 1 commit into
pingdotgg:mainfrom
sameerr03:fix/android-skill-pill-upstream
Closed

fix(mobile): restore Android composer skill pills#11060
sameerr03 wants to merge 1 commit into
pingdotgg:mainfrom
sameerr03:fix/android-skill-pill-upstream

Conversation

@sameerr03

Copy link
Copy Markdown
Contributor

What Changed

Android only. Restore the intended theme colors and cube icon for inline composer skill pills, and increase the native composer chip corner radius from 6dp to 8dp. The iOS wrapper and Swift renderer are unchanged; web and desktop are unchanged.

Normalize CSS theme colors with React Native's processColor before sending them to the Android editor. Serialize them as #RRGGBBAA, matching the native parser introduced in #10691. Draw the existing desktop cube path beside skill labels and reserve its width in the text span.

Why

Selecting a skill on Android can produce pale text on a pale fallback background, without the cube icon shown on desktop. The native color parser accepts hex but not the theme's rgba(...) strings, so the background and border silently fall back instead of using the selected theme.

Related: #7525 and the unmerged #7527 address the same color bug. This uses React Native's color processor instead of adding a CSS parser in Kotlin. #10397 changes contrast/popup styling, while #10368 replaces chip rendering as part of broader context support. This is a focused fix for the existing editor; it does not change the glass backgrounds fixed in #10998.

UI Changes

Android phone screenshots supplied by the contributor, captured before rebasing onto current upstream. The captures use different provider/skill display labels; those differences are not introduced by this PR.

Before After
Before: pale Android skill pill without a cube icon After: purple Android skill pill with cube icon and rounder corners

Validation

  • Mobile typecheck, changed-file formatting, and git diff --check passed.
  • Targeted TypeScript lint: no errors; nine existing React warnings also present in the upstream source.
  • Disposable check using the installed React Native processColor: eight cases passed, covering translucent skill background/border, opaque colors, eight-digit hex, shorthand hex, named colors, and transparency, including native-parser byte order.
  • No native rebuild or device run of the rebased head. Kotlin lint tools were unavailable locally. No iOS runtime verification.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for UI changes
  • No animation/interaction changes requiring a video

Implemented with GPT-5.6 Sol; prepared for upstream with GPT-6 in the Codex harness.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 10, 2026
@t3-code

t3-code Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

thanks for the contribution! #10368 already addresses the reported android composer skill-pill issue as part of its broader native chip-rendering changes, so we’re closing this as superseded. #10368 is still open, so the fix has not merged yet.

if the issue remains after that lands, please open a new pr with the remaining fix.

closure requested by @chrisdeeming.

@t3-code t3-code Bot closed this Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant