fix(mobile): restore Android composer skill pills - #11060
Closed
sameerr03 wants to merge 1 commit into
Closed
Conversation
Contributor
|
thanks for the contribution! #10368 already addresses the reported android composer skill-pill issue as part of its broader native chip-rendering changes, so we’re closing this as superseded. #10368 is still open, so the fix has not merged yet. if the issue remains after that lands, please open a new pr with the remaining fix. closure requested by @chrisdeeming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Android only. Restore the intended theme colors and cube icon for inline composer skill pills, and increase the native composer chip corner radius from 6dp to 8dp. The iOS wrapper and Swift renderer are unchanged; web and desktop are unchanged.
Normalize CSS theme colors with React Native's
processColorbefore sending them to the Android editor. Serialize them as#RRGGBBAA, matching the native parser introduced in #10691. Draw the existing desktop cube path beside skill labels and reserve its width in the text span.Why
Selecting a skill on Android can produce pale text on a pale fallback background, without the cube icon shown on desktop. The native color parser accepts hex but not the theme's
rgba(...)strings, so the background and border silently fall back instead of using the selected theme.Related: #7525 and the unmerged #7527 address the same color bug. This uses React Native's color processor instead of adding a CSS parser in Kotlin. #10397 changes contrast/popup styling, while #10368 replaces chip rendering as part of broader context support. This is a focused fix for the existing editor; it does not change the glass backgrounds fixed in #10998.
UI Changes
Android phone screenshots supplied by the contributor, captured before rebasing onto current upstream. The captures use different provider/skill display labels; those differences are not introduced by this PR.
Validation
git diff --checkpassed.processColor: eight cases passed, covering translucent skill background/border, opaque colors, eight-digit hex, shorthand hex, named colors, and transparency, including native-parser byte order.Checklist
Implemented with GPT-5.6 Sol; prepared for upstream with GPT-6 in the Codex harness.