Skip to content

fix(mobile): improve composer skill contrast #10397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Doctorthe113 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −6
Open

fix(mobile): improve composer skill contrast #10397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/mobile/generated-uniwind-default-theme-variables.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"--color-subtle-strong": "rgba(0, 0, 0, 0.08)",
"--color-inline-skill-background": "rgba(217, 70, 239, 0.12)",
"--color-inline-skill-border": "rgba(217, 70, 239, 0.25)",
"--color-inline-skill-foreground": "#a21caf",
"--color-inline-skill-foreground": "#000000",
"--color-primary": "#262626",
"--color-primary-foreground": "#ffffff",
"--color-primary-shadow": "#000000",
Expand Down Expand Up @@ -87,7 +87,7 @@
"--color-subtle-strong": "rgba(255, 255, 255, 0.08)",
"--color-inline-skill-background": "rgba(217, 70, 239, 0.12)",
"--color-inline-skill-border": "rgba(217, 70, 239, 0.25)",
"--color-inline-skill-foreground": "#f0abfc",
"--color-inline-skill-foreground": "#000000",
"--color-primary": "#f5f5f5",
"--color-primary-foreground": "#0a0a0a",
"--color-primary-shadow": "#000000",
Expand Down
4 changes: 2 additions & 2 deletions apps/mobile/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
--color-subtle-strong: rgba(0, 0, 0, 0.08);
--color-inline-skill-background: rgba(217, 70, 239, 0.12);
--color-inline-skill-border: rgba(217, 70, 239, 0.25);
--color-inline-skill-foreground: #a21caf;
--color-inline-skill-foreground: #000000;

/* Primary action */
--color-primary: #262626;
Expand Down Expand Up @@ -140,7 +140,7 @@
--color-subtle-strong: rgba(255, 255, 255, 0.08);
--color-inline-skill-background: rgba(217, 70, 239, 0.12);
--color-inline-skill-border: rgba(217, 70, 239, 0.25);
--color-inline-skill-foreground: #f0abfc;
--color-inline-skill-foreground: #000000;

/* Primary action */
--color-primary: #f5f5f5;
Expand Down
3 changes: 2 additions & 1 deletion apps/mobile/src/features/threads/ComposerCommandPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
import type { ServerProviderSkill, ServerProviderSlashCommand } from "@t3tools/contracts";
import type { ComposerTriggerKind } from "@t3tools/shared/composerTrigger";
import { memo } from "react";
import { Pressable, ScrollView, StyleSheet, View, type ViewStyle } from "react-native";
import { Platform, Pressable, ScrollView, StyleSheet, View, type ViewStyle } from "react-native";

import { SymbolView, type AppSymbolName } from "../../components/AppSymbol";
import { AppText as Text } from "../../components/AppText";
Expand Down Expand Up @@ -60,6 +60,7 @@ function PopoverSurface(props: { readonly children: React.ReactNode; readonly st
<GlassSurface
glassEffectStyle="clear"
tintColorClassName="accent-glass-surface"
fallbackClassName={Platform.OS === "android" ? "bg-card" : undefined}
style={baseStyle}
>
{props.children}
Expand Down
2 changes: 1 addition & 1 deletion apps/mobile/src/native/T3ComposerEditor.native.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ export function ComposerEditor({
autoFocus={props.autoFocus ?? false}
autoCorrect={props.autoCorrect ?? true}
spellCheck={props.spellCheck ?? true}
style={{ flex: 1, minHeight: 0 }}
style={{ flex: 1, minHeight: 0, padding: 2.5 }}
onComposerChange={(event) => {
const acknowledgedEventCount = acceptNativeEvent(
event.nativeEvent.eventCount,
Expand Down
Loading