fix(web): name combobox chip removal targets

[saphid]

What Changed

Every selected chip exposed the same “Remove” button name. Associate each removal button with its chip text so similar selections can be distinguished, for example “Remove Claude Opus.”

Verification

Refreshed against upstream main 761d4bac1c238ea7af4dd36b56719ad5e30771c3. Fresh targeted lint, web typecheck, and git diff --check origin/main...HEAD pass. The PR component file is byte-for-byte unchanged from the previously captured candidate, so the existing evidence still demonstrates this contribution; it has not been relabeled as a fresh capture. Refresh performed by GPT-6 Astra in the Codex harness. Fresh independent Claude review is unavailable: claude auth status reports signed out.

Browser accessibility tree confirms three distinct names. Removing the middle selection retains the first and last and returns focus to the input. Targeted lint/format and combined web typecheck pass.

This shared wrapper currently has no production callers. Verification uses an isolated three-selection fixture of the real component. No OS screen-reader speech test.

Accessibility evidence — isolated component only

This wrapper has no production callers at PR head 27bdcdfba06f71d45a5893cfb58e54a8e2d2d8be: a fresh git grep ComboboxChip under apps/web/src finds only its definitions and exports. There is no real app screen to use for a before/after capture. The prior screenshots have been removed from the product UI comparison because they showed an isolated component fixture.

The previously recorded fixture accessibility observation was: generic “Remove” names become names including each chip value; removing the middle chip retains its neighbors and returns focus to the input. That is component-level evidence, not an integrated app or OS screen-reader test. The change is nonvisual, so an appearance comparison would not demonstrate it.

Checklist

• Small, focused change
• Problem and verification explained
• Nonvisual component evidence and production-usage limitation explained

Implemented by GPT-6 Astra medium task workers, reviewed and verified by GPT-6 Astra in the T3 Code Codex harness. Direct cross-provider review attempted with claude --model claude-opus-5 --effort high --permission-mode plan --tools Read,Glob,Grep --output-format json -p …; exit 1 because OAuth expired. No Claude model ran.

Note

Fix accessible names for ComboboxChip remove controls

Associates each visible chip label with its remove control so the control's accessible name includes the chip text. Generates a React identifier for the chip label, wraps the label content in an element with that id, and passes the id to ComboboxChipRemove. The remove control now derives a hidden-text id, adds visually hidden removal text, and marks the decorative X icon as aria-hidden.

• Risk: chip markup now includes extra wrapper elements and ids; any CSS or tests that target the old chip structure in combobox.tsx may need updates.

^{Macroscope summarized 27bdcdf.}

Current-base verification

Updated to upstream main b2e15185aee22bfdee78806f2734b0a4de9c2c77 at 27bdcdfba06f71d45a5893cfb58e54a8e2d2d8be. All 3 applicable focused verification commands passed. Earlier runtime observations and media retain their stated revisions and limitations; these fresh runs do not constitute new client recordings. Fresh independent Claude review is unavailable because its OAuth credentials have expired. Refreshed by GPT-6 Astra in the Codex harness.

[macroscopeapp]

Approvability

Verdict: Approved at b20af20

Macroscope's review found this PR approvable — This is a narrowly scoped accessibility fix in one existing UI component, adding chip-specific names to removal controls without changing application data flow or other production behavior. The DOM adjustment and runtime impact are isolated and straightforward.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3-code]

reviewed diff and relevant surrounding code at 27bdcdfba06f71d45a5893cfb58e54a8e2d2d8be. no blocking findings.

the remove button references its own hidden action text followed by its chip label; ids are unique per chip and the helper is not exported. no code changes needed. browser accessibility and layout were not rerun locally.

ci snapshot: no failing or pending checks; some checks are skipped. this is a comment review, not an approval or merge.