fix(web): name the editor picker accurately - #10124
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a minimal, self-contained accessibility fix that changes only the editor picker’s accessible name from misleading copy to “Choose editor.” It does not alter visual presentation, menu behavior, editor launching, schemas, defaults, or deployment behavior. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
There was a problem hiding this comment.
reviewed diff and relevant surrounding code at 4e55fc6f5346ce0703078343b9c99406663295c3. no blocking findings.
the trigger opens editor choices in both layouts, so the new accessible name matches the action. no code changes needed. editor launching was not exercised locally.
ci snapshot: no failing or pending checks; some checks are skipped. this is a comment review, not an approval or merge.
Five more web a11y/copy commits after 00d6109. Keep the fork custom-application picker; take pingdotgg#10124's "Choose editor" label.
## What's Changed * feat(usage): pool subscription limits per provider across accounts and environments by @juliusmarminge in pingdotgg/t3code#10300 * chore(web): remove usage limits demo fixtures by @juliusmarminge in pingdotgg/t3code#10330 * fix(web): expose error disclosure state by @saphid in pingdotgg/t3code#10125 * fix(web): name the editor picker accurately by @saphid in pingdotgg/t3code#10124 * fix(web): make task row states readable by @saphid in pingdotgg/t3code#10128 * fix(web): explain hosted connection prerequisites by @saphid in pingdotgg/t3code#10129 * fix(web): name combobox chip removal targets by @saphid in pingdotgg/t3code#10127 * fix(marketing): present the Git workflow as an illustration by @saphid in pingdotgg/t3code#10130 * feat(mobile): pool usage limits across selected environments by @juliusmarminge in pingdotgg/t3code#10334 * fix(release): space automatic nightlies at least six hours apart by @t3dotgg in pingdotgg/t3code#10272 * refactor(web): share bulk thread deletion between sidebars by @t3dotgg in pingdotgg/t3code#10106 * refactor(client): share tool outcome rules by @t3dotgg in pingdotgg/t3code#10122 * refactor(server): share Claude result status and error mapping by @t3dotgg in pingdotgg/t3code#10296 * fix(server): settle inactive threads without a PR lookup by @t3dotgg in pingdotgg/t3code#10103 * fix(ssh): report remote stop failures without losing ownership by @t3dotgg in pingdotgg/t3code#10105 * perf(server): stop scanning old OpenCode parts by @t3dotgg in pingdotgg/t3code#10116 * perf(server): avoid full thread reads on turn start by @t3dotgg in pingdotgg/t3code#10108 * perf(web): skip checkpoint map rebuilds while streaming by @t3dotgg in pingdotgg/t3code#10118 * perf(server): skip plan bodies in thread summaries by @t3dotgg in pingdotgg/t3code#10341 * fix(server): skip disabled provider instances for text generation fallback by @t3dotgg in pingdotgg/t3code#10346 * fix(server): capture checkpoints before refreshing PR status by @t3dotgg in pingdotgg/t3code#10347 * fix(web): keep manual panel choices during a turn by @t3dotgg in pingdotgg/t3code#10113 * fix(threads): keep completed requests closed across clients by @t3dotgg in pingdotgg/t3code#10123 * perf(server): finish runtime messages without full thread reads by @t3dotgg in pingdotgg/t3code#10120 * refactor(server): let adapters declare context compaction by @t3dotgg in pingdotgg/t3code#10112 * fix(server): link thread PRs without an open client by @t3dotgg in pingdotgg/t3code#10101 **Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260906.1293...v0.0.39-nightly.20260906.1303 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260906.1303
Merges 141 upstream commits (`b438447f6..8b2838e`) into the fork, following the `fork-upstream-merge` skill. Landed as a merge commit; conflicts resolved by the path-policy verdicts in `docs/fork/inventory.json`. ## Merge shape 563 files landed (`git diff --stat HEAD^1 HEAD`) against 563 in the upstream range, so no upstream work was dropped. Fork delta 720 files. ## Conflicts 14 files, resolved by concern. The merge commit message names each. Two are worth carrying forward: - Upstream extracted the project action rows into `ProjectActionsList.tsx`. The fork's Edit gate now rides an `editable` prop that defaults to upstream's always-editable behavior, so the gate survives the next extraction. - Upstream moved the `agent-browser-access` setting onto its new `/settings/projects` page. `settingsSearch.ts` points that item there and drops a fork delta. ## Two things a clean merge did not show **Upstream can delete an export the fork still imports.** pingdotgg#10225 removed `ClientTracingLive` as unused. `apps/web/src/lib/runtime.ts` still installs it, and neither file conflicted, so the typecheck failed four ways on a merge git called clean. Restored with a `// Fork:` comment naming the consumer. **A green test step can hide a suite that never finished.** `vp run -r test` kills the packages still running when one of them fails. A `@t3tools/desktop` failure truncated `apps/web` and `@t3tools/mobile` after each had reported hundreds of passing files, and `verify.mjs` counted any package with labeled output as tested. Four failing web tests went unreported. The check now keys on the closing `Test Files` line and runs every unfinished package alone. ## Unsupported methods `unsupported-methods.mjs` reports 0 ADD, 0 DROP, 2 KEEP, against 61 dispatched backend methods and 131 contract methods. Getting there took a fix. The backend moved its dispatch from `crates/t3code/src/lib.rs` to `crates/t3code/src/rpc/dispatch.rs`, where every arm is a one-line call into a handler below the match. The script read the old path and reported zero dispatched methods, then read the new one and called `vcs.switchRef` a DROP, because the `unsupported_exit` that refuses it had moved out of the arm. It now tries both paths and follows an arm two calls deep. Contract changes: `provider.consumeResetCredit` and `server.getHostResources` gained `UnsupportedMethodError`; `server.getUsageSummary` lost it, which closes the item the previous merge left open. ## Feature classification **Usable as-is** — client-only, nothing new on the wire. Sidebar drag across sections with destination cues and a named drop action (pingdotgg#9731, pingdotgg#9750, pingdotgg#10378, pingdotgg#10453, pingdotgg#10464). Composer behavior: a multiline draft survives timeline scrolling (pingdotgg#10444), the composer stops collapsing on blur (pingdotgg#10437) and regains focus when you tab back (pingdotgg#10463). Panel and preview chrome: resize the floating preview from any edge (pingdotgg#10467), toolbar controls stay anchored (pingdotgg#10478), the stuck resize cursor clears (pingdotgg#10461), the browser hides as the right panel closes (pingdotgg#10385), manual panel choices hold during a turn (pingdotgg#10113). Settings and accessibility polish (pingdotgg#10177, pingdotgg#10262, pingdotgg#10415, pingdotgg#10258, pingdotgg#10124, pingdotgg#10125, pingdotgg#10127, pingdotgg#10128, pingdotgg#10175). Performance (pingdotgg#10413, pingdotgg#10190, pingdotgg#10118). Plus the GitHub mark on `github.com` links (pingdotgg#10324), the Tux icon for WSL (pingdotgg#8511), a remembered usage page selection (pingdotgg#10189), project settings in the legacy sidebar menu (pingdotgg#10021), and text-only preview snapshots (pingdotgg#10232). **Unsupported in Moatless** — resolves to a refusal, or falls through to its own empty state. Each is recorded in `docs/fork/gaps.md`: - Reset credits through the hub and CLIProxyAPI (pingdotgg#10462, pingdotgg#10395, pingdotgg#10308). `provider.consumeResetCredit`, new union entry. `UsageLimits.tsx` catches the refusal and shows "Could not use the reset credit." - Balancing new threads across connected machines (pingdotgg#9895, pingdotgg#10433, pingdotgg#10407). `server.getHostResources`, new union entry. Nothing polls until a user picks automatic routing, and the composer then reads "Auto balance unavailable." - Onboarding: import grouped by repository (pingdotgg#10493), the shared multi-computer wizard (pingdotgg#10465), agent install without Node or npm (pingdotgg#10402). All ride `agentSessions.scan` and `.import`, an existing gap. - Shared project defaults and scoped overrides (pingdotgg#9754). The page reads, and every write goes through `server.updateSettings`, which the backend does not dispatch. - Two new `orchestration.dispatchCommand` types: `thread.active.reorder` (pingdotgg#9729) and `thread.user-input.dismiss` (pingdotgg#10431). Both are ordinary controls, a sidebar drag and a Dismiss button, and a dispatched command cannot be refused per type. That is the standing _A command cannot be refused_ gap, now 26 members wide. **Backend behavior to consider reproducing in Moatless** — upstream server fixes whose behavior the fork's client assumes: - Invalid script IDs no longer crash threads (pingdotgg#10019). The fork ships project scripts, so this one is worth reading first. - Settlement: settle inactive threads without a PR lookup (pingdotgg#10103), skip disabled settlement lookups (pingdotgg#10424), settle threads with unanswered async questions (pingdotgg#10400). - Interrupted threads stay resumable after a restart (pingdotgg#10421). - Completed requests stay closed across clients (pingdotgg#10123). - Placeholder branches are followed after a checkout updates (pingdotgg#10441). - A thread's PR links without an open client (pingdotgg#10101), and checkpoints are captured before a PR status refresh (pingdotgg#10347). - Adapters declare their own context compaction (pingdotgg#10112). - Transcripts with oversized tool records import (pingdotgg#10430), and git status scans are skipped while the index is locked (pingdotgg#9845). - Usage limits pool per provider across accounts and environments (pingdotgg#10300). The client renders what `server.getUsageSummary` returns, so this shows something only if the Moatless payload carries per-account limits. Mobile, marketing, desktop, provider adapters and release tooling are not this fork's surface and are not classified. ## Also fixed here, and not upstream's doing - Three `browser-*` search items still routed to `/settings/integrations`, which the fork owns for its Moatless administration page. A non-administrator who searched for them was redirected away from the result. - `moatless/listSearch.ts` carried no fork-only declaration. - `pnpm fmt:check` failed on 294 files, 293 of them orval output. The generator now formats what it writes through an `afterAllFilesWrite` hook. - `@t3tools/moatless-api` exported `./generated`, a barrel that is never checked in. ## Verification `inventory-check.mjs` clean. `verify.mjs` green on seven checks: duplicate-adds, tripwires, resolution-check, unsupported-methods, `fmt:check` (3876 files), `lint` and `typecheck`. `test` is red on one package, and it is the machine. `@t3tools/desktop`'s `bundled libsecret helper` shells out to `pkg-config` for `libsecret-1`, which this sandbox does not have; it fails the same way when retried alone. Everything else passes: `apps/web` 369 files, `t3` 291, `@t3tools/mobile` 149, `t3code-relay` 27, `@t3tools/client-runtime` 71, plus the smaller packages. `spec:check` cannot run in a sandbox: it needs a sibling `moatless` checkout or a deployment URL and has neither. Written by Claude Opus 5 in Claude Code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- Moatless task: https://moatless.soaplabstest.com/tasks/8d348ecf-f9cb-4e65-b96b-6c1054a8ed33
What Changed
The normal editor menu announced “Copy options,” although it chooses an editor. Give both normal and compact triggers the accurate “Choose editor” accessible name.
Verification
Refreshed against upstream main
761d4bac1c238ea7af4dd36b56719ad5e30771c3. Fresh targeted lint, web typecheck, andgit diff --check origin/main...HEADpass. The PR component file is byte-for-byte unchanged from the previously captured candidate, so the existing evidence still demonstrates this contribution; it has not been relabeled as a fresh capture. Refresh performed by GPT-6 Astra in the Codex harness. Fresh independent Claude review is unavailable:claude auth statusreports signed out.Browser accessibility tree reproduced the old name and confirms the new name. The actual chat-header menu opens and Escape restores focus. Targeted lint/format and combined web typecheck pass.
Web and Electron shared UI; Electron-specific editor launching was not exercised.
UI Changes
Before: upstream
6270a6f88; after:4b95a70d0. The visible design is unchanged; accessible name changes from Copy options to Choose editor.Before
After
The change is nonvisual. Screenshots provide control context only; verification relies on the accessibility-tree observations described above. No animated GIF is included because unchanged UI footage does not demonstrate the semantic change.
Checklist
Implemented by GPT-6 Astra medium task workers, reviewed and verified by GPT-6 Astra in the T3 Code Codex harness. Direct cross-provider review attempted with
claude --model claude-opus-5 --effort high --permission-mode plan --tools Read,Glob,Grep --output-format json -p …; exit 1 because OAuth expired. No Claude model ran.Current-base verification
Updated to upstream main
b2e15185aee22bfdee78806f2734b0a4de9c2c77at4e55fc6f5346ce0703078343b9c99406663295c3. All 3 applicable focused verification commands passed. Earlier runtime observations and media retain their stated revisions and limitations; these fresh runs do not constitute new client recordings. Fresh independent Claude review is unavailable because its OAuth credentials have expired. Refreshed by GPT-6 Astra in the Codex harness.Note
Fix accessible label of
OpenInPickereditor trigger to "Choose editor"Sets the editor menu trigger button's accessible label to the constant "Choose editor" in OpenInPicker.tsx. The label no longer varies with the
compactprop, so both layouts announce the same name.Macroscope summarized 4e55fc6.