*: upgrade golang to 1.25.5 (#63475) by ti-chi-bot · Pull Request #65043 · pingcap/tidb

ti-chi-bot · 2025-12-15T11:50:30Z

This is an automated cherry-pick of #63475

What problem does this PR solve?

Security vulnerabilities

Issue Number: close #62981
Issue Number: ref #62487

From go 1.24.0 golang's switch its builtin map to swiss table: https://go.dev/blog/swisstable.
TiDB manually estimates a map's memory usage for memory control, since the implementation of map is changed, we need adopt the memory estimation for the new map.
CRDB uses another specified variables allocator to allocate and release memory used by a Map.
- Such allocator is supposed to have the ability to record memory usage info.

What changed and how does it work?

Solution

Remove all bInMap and calculate approximate heap size dynamically
- Capacity of swisstable is 1024(maxTableCapacity) which means the overhead of split(rehash) is quite low
- It is difficult to simply determine the timing of each swisstable split(growthLeft == 0) when dirLen is large
Opportunities to recalculate size:
- Increment of max len reaches 1024 or double len
- Approximate size: groupSize * maxLen * 204 / 1000
  - 204: linear fitting of different kinds of map[K]V
Sampling statistics of heap size:
- calculate approximate valid swisstable number & total heap size of map
Check abi each time then modify func checkMapABI before upgrading golang version

TODO

Upgrade client_golang and testify(some unit tests will break if using testify @ v1.11.1).

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

Benchmark

TPC-H

ENV:

tidb x 1: 4c 20g
pd x 1, tikv x 1
TPC-H (sf 8)
set global tidb_mem_quota_query=20<<30

TPC-H (sf 8)	go1.23.12	go1.25.x
Q1	6.07	6.07
Q2	1.58	1.31
Q3	2.99	2.92
Q4	1.24	1.17
Q5	4.73	4.6
Q6	2.52	2.72
Q7	3.99	3.93
Q8	2.05	1.98
Q9	8.56	8.29
Q10	2.25	2.18
Q11	1.24	1.11
Q12	4.19	4.13
Q13	4.87	4.19
Q14	3.12	2.92
Q15	5.6	5.67
Q16	1.24	1.31
Q17	12.99	13.59
Q18	14.66	15.33
Q19	6.07	6.21
Q20	3.19	3.12
Q21	5.34	5.2
Q22	1.44	1.38
SUM	99.93	99.33

TPC-C

Env:

tidb: 4c 2g
- no copr-cache
pd x 1, tikv x 1

go1.23.12

warehouses: 4, threads: 100, duration: 3m
- tpmC: 22262.8, tpmTotal: 49279.3, efficiency: 43279.1%
warehouses: 4, threads: 200, duration: 3m
- tpmC: 18614.0, tpmTotal: 41521.7, efficiency: 36185.8%
- Error 8176: kill the top-1 SQL

go1.25.x

warehouses: 4, threads: 100, duration: 3m
- tpmC: 22944.3, tpmTotal: 50980.4, efficiency: 44604.0%
warehouses: 4, threads: 200, duration: 3m
- tpmC: 20613.8, tpmTotal: 45561.0, efficiency: 40073.5%
- Error 8176: kill the top-1 SQL

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot · 2025-12-15T11:50:35Z

@solotzg This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

ti-chi-bot · 2025-12-15T11:50:36Z

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>

codecov · 2025-12-15T13:32:56Z

Codecov Report

❌ Patch coverage is 84.64419% with 41 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-8.5@44b12e6). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-8.5     #65043   +/-   ##
================================================
  Coverage               ?   72.6272%           
================================================
  Files                  ?       1676           
  Lines                  ?     468447           
  Branches               ?          0           
================================================
  Hits                   ?     340220           
  Misses                 ?     105588           
  Partials               ?      22639

Flag	Coverage Δ
integration	`49.7497% <66.6666%> (?)`
unit	`64.9378% <77.9026%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9278% <0.0000%> (?)`
parser	`∅ <0.0000%> (?)`
br	`55.1537% <0.0000%> (?)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>

…nto cherry-pick-63475-to-release-8.5

Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>

solotzg · 2025-12-16T01:41:52Z

export GOTOOLCHAIN := go1.25.5
CP statistics: fix flaky test TestSyncLoadOnObjectWhichCanNotFoundInStorage #58164
distsqltest_test -> moderate
txntest_test -> long
analyzetest_test -> moderate
sessiontest_test -> long

solotzg · 2025-12-16T02:28:20Z

/cc @windtalker @hawkingrei @bb7133 @D3Hunter

windtalker

lgtm

ti-chi-bot · 2025-12-16T02:32:47Z

[LGTM Timeline notifier]

Timeline:

2025-12-16 02:30:57.446061233 +0000 UTC m=+1526602.259838815: ☑️ agreed by windtalker.
2025-12-16 02:32:46.029723492 +0000 UTC m=+1526710.843501094: ☑️ agreed by hawkingrei.

D3Hunter · 2025-12-16T02:36:56Z

/approve

ti-chi-bot · 2025-12-16T02:45:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, hawkingrei, lance6716, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [D3Hunter,hawkingrei,lance6716,windtalker]
~~dumpling/OWNERS~~ [lance6716]
~~pkg/lightning/OWNERS~~ [D3Hunter,lance6716]
~~pkg/parser/OWNERS~~ [D3Hunter]
~~pkg/statistics/OWNERS~~ [hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

purelind · 2025-12-16T02:46:21Z

/unhold

wuhuizuo · 2025-12-16T06:30:11Z

/test ?

ti-chi-bot · 2025-12-16T06:30:15Z

@wuhuizuo: The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pull-check-deps

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-integration-tidb-tools-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-sqllogic-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/release-8.5/pull_build

pingcap/tidb/release-8.5/pull_check

pingcap/tidb/release-8.5/pull_check2

pingcap/tidb/release-8.5/pull_mysql_test

pingcap/tidb/release-8.5/pull_unit_test

pull-check-deps

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-12-16T06:30:26Z

@wuhuizuo: The following commands are available to trigger required jobs:

/test fast_test_tiprow_for_release

Use /test all to run all jobs.

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-12-16T06:30:30Z

@ti-chi-bot[bot]: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow_for_release

Use /test all to run all jobs.

Details

In response to this:

@wuhuizuo: The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pull-check-deps
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-integration-tidb-tools-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-sqllogic-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/release-8.5/pull_build
pingcap/tidb/release-8.5/pull_check
pingcap/tidb/release-8.5/pull_check2
pingcap/tidb/release-8.5/pull_mysql_test
pingcap/tidb/release-8.5/pull_unit_test
pull-check-deps
In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

wuhuizuo · 2025-12-16T06:32:30Z

/test pull-unit-test-ddlv1

wuhuizuo · 2025-12-16T06:32:39Z

/test unit-test

tiprow · 2025-12-16T06:32:45Z

@wuhuizuo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow_for_release

Use /test all to run all jobs.

Details

In response to this:

/test pull-unit-test-ddlv1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-12-16T06:32:54Z

@wuhuizuo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow_for_release

Use /test all to run all jobs.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

wuhuizuo · 2025-12-16T06:33:01Z

/test mysql-test

tiprow · 2025-12-16T06:33:17Z

@wuhuizuo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow_for_release

Use /test all to run all jobs.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

solotzg · 2025-12-16T07:17:05Z

/retest

ti-chi-bot mentioned this pull request Dec 15, 2025

*: upgrade golang to 1.25.5 #63475

Merged

3 tasks

ti-chi-bot bot added the do-not-merge/cherry-pick-not-approved label Dec 15, 2025

ti-chi-bot assigned solotzg Dec 15, 2025

1: go1.25.

0e018a0

Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>

solotzg force-pushed the cherry-pick-63475-to-release-8.5 branch from 5a072e8 to 0e018a0 Compare December 15, 2025 13:04

ti-chi-bot bot added the sig/planner SIG: Planner label Dec 15, 2025

2: CP pingcap#65047

58df4c9

Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>

hawkingrei and others added 3 commits December 15, 2025 22:07

update bazel config

a5628d5

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

3: txntest_test timeout = "long"

1d9fe6c

Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>

Merge remote-tracking branch 'bot/cherry-pick-63475-to-release-8.5' i…

eb233ae

…nto cherry-pick-63475-to-release-8.5

ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 15, 2025

4: analyzetest_test, sessiontest_test

817e907

Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>

solotzg mentioned this pull request Dec 16, 2025

[deprecated] #64955

Closed

ti-chi-bot bot requested review from D3Hunter, bb7133, hawkingrei and windtalker December 16, 2025 02:28

windtalker approved these changes Dec 16, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 16, 2025

lance6716 approved these changes Dec 16, 2025

View reviewed changes

ti-chi-bot bot added the approved label Dec 16, 2025

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2025

wuhuizuo added the priority/P0 The issue has P0 priority. label Dec 16, 2025

ti-chi-bot merged commit 30107c0 into pingcap:release-8.5 Dec 16, 2025
20 of 28 checks passed

ti-chi-bot deleted the cherry-pick-63475-to-release-8.5 branch December 16, 2025 08:58

pingcap deleted a comment from ti-chi-bot bot Dec 16, 2025

This was referenced Feb 5, 2026

Cherry-pick for release-8.5-materialized-view branch #66061

Open

*: Cherry-pick pr-65871 into release-8.5-materialized-view branch #66062

Closed

*: upgrade golang to 1.25 in materialized_view branch #66128

Closed

Comments

Conversation

ti-chi-bot commented Dec 15, 2025

What problem does this PR solve?

What changed and how does it work?

Check List

Benchmark

TPC-H

TPC-C

go1.23.12

go1.25.x

Release note

Uh oh!

ti-chi-bot commented Dec 15, 2025

Uh oh!

ti-chi-bot bot commented Dec 15, 2025

Uh oh!

codecov bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

solotzg commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

solotzg commented Dec 16, 2025

Uh oh!

windtalker left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Dec 16, 2025

[LGTM Timeline notifier]

Uh oh!

D3Hunter commented Dec 16, 2025

Uh oh!

ti-chi-bot bot commented Dec 16, 2025

Uh oh!

purelind commented Dec 16, 2025

Uh oh!

wuhuizuo commented Dec 16, 2025

Uh oh!

ti-chi-bot bot commented Dec 16, 2025

Uh oh!

tiprow bot commented Dec 16, 2025

Uh oh!

tiprow bot commented Dec 16, 2025

Uh oh!

wuhuizuo commented Dec 16, 2025

Uh oh!

wuhuizuo commented Dec 16, 2025

Uh oh!

tiprow bot commented Dec 16, 2025

Uh oh!

tiprow bot commented Dec 16, 2025

Uh oh!

wuhuizuo commented Dec 16, 2025

Uh oh!

tiprow bot commented Dec 16, 2025

Uh oh!

solotzg commented Dec 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov bot commented Dec 15, 2025 •

edited

Loading

solotzg commented Dec 16, 2025 •

edited

Loading