Skip to content

Comments

[deprecated]#64955

Closed
solotzg wants to merge 10 commits intopingcap:release-8.5from
solotzg:release-8.5-go1.25
Closed

[deprecated]#64955
solotzg wants to merge 10 commits intopingcap:release-8.5from
solotzg:release-8.5-go1.25

Conversation

@solotzg
Copy link
Contributor

@solotzg solotzg commented Dec 10, 2025

Redirect #65043

Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 10, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 10, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added component/dumpling This is related to Dumpling of TiDB. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 10, 2025
@tiprow
Copy link

tiprow bot commented Dec 10, 2025

Hi @solotzg. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 89 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-8.5@616e914). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #64955   +/-   ##
================================================
  Coverage               ?   45.9002%           
================================================
  Files                  ?       1583           
  Lines                  ?     452074           
  Branches               ?          0           
================================================
  Hits                   ?     207503           
  Misses                 ?     226198           
  Partials               ?      18373           
Flag Coverage Δ
integration 45.9002% <66.6666%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling ∅ <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 2.7447% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>
@tiprow
Copy link

tiprow bot commented Dec 10, 2025

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@solotzg
Copy link
Contributor Author

solotzg commented Dec 11, 2025

/cc @hawkingrei

@ti-chi-bot ti-chi-bot bot requested a review from hawkingrei December 11, 2025 02:03
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 11, 2025
Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>
…o1.25

Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>
Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>
Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>
@solotzg
Copy link
Contributor Author

solotzg commented Dec 15, 2025

/retest

2 similar comments
@EmmaDuDu
Copy link

/retest

@EmmaDuDu
Copy link

/retest

@ti-chi-bot ti-chi-bot bot added the sig/planner SIG: Planner label Dec 15, 2025
Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hawkingrei
Once this PR has been reviewed and has the lgtm label, please assign d3hunter, lance6716 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 15, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-15 14:09:52.632307828 +0000 UTC m=+1482137.446085410: ☑️ agreed by hawkingrei.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 15, 2025

@solotzg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-ddlv1 f5b279d link true /test pull-unit-test-ddlv1
idc-jenkins-ci-tidb/check_dev_2 65802cb link true /test check-dev2
idc-jenkins-ci-tidb/unit-test 65802cb link true /test unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@solotzg solotzg changed the title *: upgrade golang to 1.25.5 for release-8.5 (#63475) wip: upgrade golang to 1.25.5 for release-8.5 (#63475) Dec 15, 2025
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 15, 2025
@solotzg solotzg changed the title wip: upgrade golang to 1.25.5 for release-8.5 (#63475) [dnm]: upgrade golang to 1.25.5 for release-8.5 (#63475) Dec 16, 2025
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2025
@solotzg solotzg changed the title [dnm]: upgrade golang to 1.25.5 for release-8.5 (#63475) [dnm] Dec 16, 2025
@solotzg
Copy link
Contributor Author

solotzg commented Dec 16, 2025

Close and redirect #65043

@solotzg solotzg changed the title [dnm] [deprecated] Dec 16, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 16, 2025

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/invalid-title label, please follow title format, for example pkg [, pkg2, pkg3]: what is changed or *: what is changed.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@solotzg solotzg closed this Dec 16, 2025
@solotzg solotzg deleted the release-8.5-go1.25 branch December 16, 2025 03:00
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 16, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. component/dumpling This is related to Dumpling of TiDB. do-not-merge/invalid-title do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. ok-to-test Indicates a PR is ready to be tested. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants