Skip to content

Comments

test: set longer timeout for distsqltest#65047

Closed
you06 wants to merge 1 commit intopingcap:release-8.5from
you06:8.5/distsql-timeout-moderate
Closed

test: set longer timeout for distsqltest#65047
you06 wants to merge 1 commit intopingcap:release-8.5from
you06:8.5/distsql-timeout-moderate

Conversation

@you06
Copy link
Contributor

@you06 you06 commented Dec 15, 2025

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Set the timeout to moderate(300s) because timeout = "short"(60s) is too short for some environment running the distsql test.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Dec 15, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 15, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be LGTMed and approved by the reviewers firstly.
  2. For pull requests to TiDB-x branches, it must have no failed tests.
  3. AFTER it has lgtm and approved labels, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign djshow832 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tiprow
Copy link

tiprow bot commented Dec 15, 2025

Hi @you06. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

solotzg added a commit to solotzg/tidb that referenced this pull request Dec 15, 2025
Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>
solotzg added a commit to ti-chi-bot/tidb that referenced this pull request Dec 15, 2025
Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-8.5@44b12e6). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #65047   +/-   ##
================================================
  Coverage               ?   76.4406%           
================================================
  Files                  ?       1684           
  Lines                  ?     468573           
  Branches               ?          0           
================================================
  Hits                   ?     358180           
  Misses                 ?      88332           
  Partials               ?      22061           
Flag Coverage Δ
integration 49.5912% <ø> (?)
unit 72.1554% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 57.6353% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

solotzg added a commit to solotzg/tidb that referenced this pull request Dec 15, 2025
Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>
@you06
Copy link
Contributor Author

you06 commented Dec 15, 2025

Applied the change in another PR.

@you06 you06 closed this Dec 15, 2025
ti-chi-bot added a commit that referenced this pull request Dec 16, 2025
* 1: go1.25.

Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>

* 2: CP #65047

Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>

* update bazel config

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

* 3: txntest_test timeout = "long"

Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>

* 4: analyzetest_test, sessiontest_test

Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>

---------

Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Co-authored-by: Zhigao TONG <tongzhigao@pingcap.com>
Co-authored-by: Weizhen Wang <wangweizhen@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant