Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13897 remove collections #13898

Merged
merged 3 commits into from
Mar 13, 2019
Merged

T13897 remove collections #13898

merged 3 commits into from
Mar 13, 2019

Conversation

niden
Copy link
Member

@niden niden commented Mar 13, 2019

Hello!

Type: new feature
Link to issue: #13893

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Added case insensitive flag in remove()

Thanks

@niden niden added enhancement Enhancement to the framework breaks bc Functionality that breaks Backwards Compatibility labels Mar 13, 2019
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #13898 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13898      +/-   ##
==========================================
+ Coverage   67.85%   67.85%   +<.01%     
==========================================
  Files         468      468              
  Lines       93366    93380      +14     
==========================================
+ Hits        63355    63365      +10     
- Misses      30011    30015       +4
Impacted Files Coverage Δ
ext/phalcon/session/bag.zep.c 87.67% <0%> (-0.82%) ⬇️
ext/phalcon/registry.zep.c 77.77% <0%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e720ea...692b288. Read the comment docs.

@niden niden merged commit 248d5d5 into phalcon:4.0.x Mar 13, 2019
@niden niden deleted the T13897-remove-collections branch March 29, 2019 23:43
@niden niden added documentation Documentation required and removed documentation Documentation required labels Apr 9, 2019
@niden niden added the 4.0 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants