Skip to content
This repository was archived by the owner on Apr 14, 2026. It is now read-only.

Use enum-compat instead of enum34 directly#131

Merged
peplin merged 1 commit into
peplin:masterfrom
jeanregisser:master
Sep 16, 2017
Merged

Use enum-compat instead of enum34 directly#131
peplin merged 1 commit into
peplin:masterfrom
jeanregisser:master

Conversation

@jeanregisser
Copy link
Copy Markdown
Contributor

@jeanregisser jeanregisser commented Jun 19, 2017

Hi,

I'm getting an error in Home Assistant running python 3.6 that uses your library: AttributeError: module 'enum' has no attribute 'IntFlag'

It appears enum34 is not meant to be installed in Python versions 3.4+
so this fixes it.

Let me know what you think,

@balloob
Copy link
Copy Markdown

balloob commented Jul 29, 2017

I would love to see this PR get merged. It doesn't contain any breaking changes and makes sure modern versions of Python can be used with this lib.

From the https://github.com/jstasiak/enum-compat README:

This is a virtual package, its whole purpose is to install enum34 on Python older than 3.4. On Python 3.4+ it’s a no-op.

@peplin peplin merged commit b57b41c into peplin:master Sep 16, 2017
@peplin
Copy link
Copy Markdown
Owner

peplin commented Sep 16, 2017

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants