Uninstall enum34 in python3.6 docker image#8103
Merged
balloob merged 2 commits intoJun 24, 2017
Merged
Conversation
This is a short term fix for home-assistant#7733 What's happening is the following dependencies are pulling enum34: - pygatt - libsoundtouch - yeelight However, enum34 is not meant to be installed in Python versions 3.4+ and causing the `AttributeError: module 'enum' has no attribute 'IntFlag'`` I've submitted patches to these projects so we don't have to do this manual uninstall in the future.
|
@jeanregisser, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @michaelarnauts and @mathewpeterson to be potential reviewers. |
Contributor
|
Hi @jeanregisser, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
CharlesBlonde
added a commit
to CharlesBlonde/home-assistant
that referenced
this pull request
Jun 21, 2017
fabaff
pushed a commit
that referenced
this pull request
Jun 21, 2017
Member
|
Thanks for this fix! If we make a 0.47.2 I'll make sure to include this. |
Member
|
Also thanks for trying to get the broken dependencies fixed! |
balloob
added a commit
that referenced
this pull request
Jun 24, 2017
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* Uninstall enum34 in python3.6 docker image This is a short term fix for home-assistant#7733 What's happening is the following dependencies are pulling enum34: - pygatt - libsoundtouch - yeelight However, enum34 is not meant to be installed in Python versions 3.4+ and causing the `AttributeError: module 'enum' has no attribute 'IntFlag'`` I've submitted patches to these projects so we don't have to do this manual uninstall in the future. * Update Dockerfile
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
…e-assistant#8182) * Revert "Uninstall enum34 in python3.6 docker image (home-assistant#8103)" This reverts commit 45f6f44. * Revert "Add libboost-python1.62-dev (fixes home-assistant#7851) (home-assistant#7868)" This reverts commit f1290d3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a short term fix for #7733
What's happening is the following dependencies are pulling
enum34:pygattlibsoundtouchyeelightHowever, enum34 is not meant to be installed in Python versions 3.4+
and causing the
AttributeError: module 'enum' has no attribute 'IntFlag'I've submitted patches to these projects so we don't have to do this
manual uninstall in the future.
Let me know what you think: