Block dependencies that depend on enum34#8698
Merged
Merged
Conversation
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* Block dependencies that depend on enum34 * Remove uninstalling enum34 * Update validation script * Add constraints to tox.ini * Upgrade yeelight to version that uses enum-compat * Disable sensor.skybeacon * Lint
|
Looks like pygatt may now be fixed: https://github.com/peplin/pygatt/blob/master/CHANGELOG.rst. Could the skybeacon component be re-enabled now, or is more work required? |
Member
Author
|
If a new release of pygatt has been done, you can submit a PR to Home Assistant to uncomment and upgrade the dependency for skybeacon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This blocks enum34 from being installed. It is a backport of the Python 3.4 enum module for Python 2.7-3.3. It is never needed for Home Assistant.
When installed in Python 3.6, it will blow up things that depend on enum.
This change will fail any dependency that tries to install enum34. As these dependencies have to depend on
enum-compatinstead, which will only installenum34when necessary.See earlier work done in #8103
As this is very annoying, I'm planning on disabling components/platforms that currently depend on requirements that pull in enum34. Based on the current list that will only be sensor.skybeacon.
Found violating packages with
pipdeptree --reverse --packages enum34:The
pygattandyeelightPRs have been submitted over a month ago and have not gotten any response.Related issue (if applicable): fixes #7733