-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search updates #99
Comments
Re: pagination, I am a bit stumped since the count = len(qdrant.search(
collection_name=(
query.collection_name or DEFAULT_QDRANT_COLLECTION_NAME
),
query_vector=query_vec,
limit=1e99, # get everything above the threshold
offset=offset,
score_threshold=score_threshold,
)) This would be really non-performant, however. I guess we could still paginate but adopt an "infinite scroll" type scenario. Just let them keep paging, incrementing the offset by the previous value + limit, until results are of length 0. With a low enough |
No -- use the limit and offset of the search. So, by default you search with limit = 100 and offset = 0. You display these results with a "page 2" button. If the user clicks "page 2", then you repeat the search with limit = 100 and offset = 100. Offset = (page-1) * limit There is no "number of results", in this case. |
I feel pretty good about the updates here. Maybe some UI/UX/styling things could be done, but the functionality is basically there. |
Two things should be completed:
|
Some search results that come up for me, when I click on them, it says "not found". I think this may just reflect that the re-indexing is still needed, is that right? |
This is related to pepkit/pepembed#2 @khoroshevskyi it would be nice to get this stuff fleshed out prior to the latest release of PEPhub |
Seems like this still needs to occur |
Still open because of the indexing strategy we are still using. |
I'll close this since really the re-indexing is a |
Brainstorming some ideas for bringing the search to the next level?
The text was updated successfully, but these errors were encountered: