Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6.0 UI polishing 🧼 and authentication updates 🔐 #90

Closed
6 of 7 tasks
nsheff opened this issue Feb 14, 2023 · 7 comments
Closed
6 of 7 tasks

Release 0.6.0 UI polishing 🧼 and authentication updates 🔐 #90

nsheff opened this issue Feb 14, 2023 · 7 comments
Assignees
Milestone

Comments

@nsheff
Copy link
Contributor

nsheff commented Feb 14, 2023

  1. On first "geo" namespace search hit, "View" link is broken. View link is not propogating tag
  2. On edit, "Project config" fetch is very slow. There may be 2 related problems here: timeout to wait for monaco editor before fetching, and then the time it's taking for the fetch of the actual data after the editor has loaded.
  3. Saving fails with "Network Error"
  4. geo_recent has "None" in project name, no links work
  5. on Eido validator page, link to PEP documentation is broken
  6. On main page, on "My PEPs" button, move icon to the left, like other labels.
  7. validator is still not working with multi-file peps
@nsheff nsheff added this to the Version 0.5.1 milestone Feb 28, 2023
@nleroy917 nleroy917 changed the title Release 0.5.0 UI polishing issues Release 0.6.0 UI polishing issues Mar 1, 2023
@nleroy917 nleroy917 pinned this issue Mar 1, 2023
@nleroy917 nleroy917 changed the title Release 0.6.0 UI polishing issues Release 0.6.0 UI polishing 🧼 and authentication updates 🔐 Mar 1, 2023
@nleroy917 nleroy917 modified the milestones: Version 0.5.1, Version 0.6.0 Mar 1, 2023
@nsheff
Copy link
Contributor Author

nsheff commented Mar 1, 2023

Well, I was thinking this would be 2 steps, a bunch these of just 0.5.0 things that were broken...

In other words, some of these I want to finish before we're done with 0.5.0. Some of them I marked as 0.6.0 since they seemed like a "next version" type of thing. Unless you think we can do 0.6.0 in the next day or two. If it's just a numbering disagreement then we should switch the next stuff to 0.7.0, but I'm just not sure it was worth changing everything around for that

@nleroy917
Copy link
Member

We made a release for 0.5.0 and 0.5.1, so that's why I was bringing them into 0.6.0

@nsheff
Copy link
Contributor Author

nsheff commented Mar 1, 2023

We made a release for 0.5.0 and 0.5.1, so that's why I was bringing them into 0.6.0

Oh whoops, my mistake. I thought we were still on 0.5.0

@nleroy917
Copy link
Member

nleroy917 commented Mar 1, 2023

geo_recent has "None" in project name, no links work

This one was weird. the name attribute in the peppy Project representation was set to None and that was causing issues... It might be something to do with the way geo_recent is being loaded into pephub.

@nleroy917
Copy link
Member

I've got lots of things pushed to dev_nathan. In a few days I should be done with most but a few might be worth a bigger discussion and require help:

  1. Authentication Flow
  2. Saving changes fail in production.

@nleroy917
Copy link
Member

This will be closed since the latest version was released.

@nleroy917 nleroy917 unpinned this issue Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants