Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mergev0.6.0 into dev #107

Merged
merged 62 commits into from
Mar 8, 2023
Merged

Mergev0.6.0 into dev #107

merged 62 commits into from
Mar 8, 2023

Conversation

nleroy917
Copy link
Member

@nleroy917 nleroy917 commented Mar 6, 2023

@nleroy917 nleroy917 requested review from khoroshevskyi and nsheff and removed request for khoroshevskyi March 6, 2023 20:34
@khoroshevskyi
Copy link
Member

khoroshevskyi commented Mar 7, 2023

Errors:

  • can't open private projects. I can see this private in the list of my projects and edit it, but I can't open it.
    image

  • Validation is failing in simplest files. Error message in console:

Traceback (most recent call last):
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/uvicorn/protocols/http/h11_impl.py", line 407, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 78, in __call__
    return await self.app(scope, receive, send)
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/fastapi/applications.py", line 270, in __call__
    await super().__call__(scope, receive, send)
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/starlette/applications.py", line 124, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/starlette/middleware/cors.py", line 92, in __call__
    await self.simple_response(scope, receive, send, request_headers=headers)
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/starlette/middleware/cors.py", line 147, in simple_response
    await self.app(scope, receive, send)
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in __call__
    raise e
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in __call__
    await self.app(scope, receive, send)
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/starlette/routing.py", line 706, in __call__
    await route.handle(scope, receive, send)
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/starlette/routing.py", line 276, in handle
    await self.app(scope, receive, send)
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/starlette/routing.py", line 66, in app
    response = await func(request)
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/fastapi/routing.py", line 235, in app
    raw_response = await run_endpoint_function(
  File "/home/bnt4me/virginia/venv/pephub/lib/python3.10/site-packages/fastapi/routing.py", line 161, in run_endpoint_function
    return await dependant.call(**values)
  File "/home/bnt4me/virginia/repos/pephub/./pephub/routers/eido/eido.py", line 248, in validate_raw
    project_config_dict["sample_table"] = "sample_table.csv"
TypeError: 'str' object does not support item assignment

I didn't test everything, especially search. I will test it soon

@nleroy917
Copy link
Member Author

nleroy917 commented Mar 7, 2023

Validation is failing in simplest files. Error message in console:

can you tell me which one? I can't reproduce this.

@khoroshevskyi
Copy link
Member

Validation is failing in simplest files. Error message in console:

can you tell me which one? I can't reproduce this.

e.g. http://localhost:8000/Khoroshevskyi/new1?tag=new1
This is sample that was created using: Submit a new PEP/new

@nleroy917
Copy link
Member Author

nleroy917 commented Mar 7, 2023

Notes from meeting 03/07/2023

  • Remove "Number of results" on search Done.
  • Make changes to authentication to support code flow Done.
    • Add some documentation for this so people can write cli's and SPAs Done.
  • Try to finish up those last lingering bugs
  • "Create" not "New" Done.

@nleroy917
Copy link
Member Author

@khoroshevskyi I want to merge this ASAP... do you have a reproducible example of your issue yet so I can bug fix? If not I will merge this soon.

@khoroshevskyi
Copy link
Member

@khoroshevskyi I want to merge this ASAP... do you have a reproducible example of your issue yet so I can bug fix? If not I will merge this soon.

Reproducible example:

  1. Create new project
  2. Validate it
  • after your new changes I am getting new error, so I can't even start pophub:
    image

@nleroy917
Copy link
Member Author

Make sure you pull again.. that error you are seeing should have been fixed

@nleroy917 nleroy917 changed the base branch from master to dev March 8, 2023 17:39
@nleroy917 nleroy917 merged commit 0932ebf into dev Mar 8, 2023
@nleroy917 nleroy917 changed the title Release v0.6.0 🌼 Mergev0.6.0 into dev Mar 8, 2023
@nleroy917 nleroy917 deleted the dev_nathan branch April 3, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants