[swittk]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.
• Link this pull request to an issue.

Issue

For optional arrays (e.g. field?: ClassName[] ), the equalTo function has always shown a type error when we try to match, when the underlying runtime has always worked (Parse supports matching of "array contains element" natively). This only happens when the array is optional; required arrays types already allow element matching

Example

class MyClass extends Parse.Object<{ myArrayField?: Parse.User[]  }> {}

const u = new Parse.User();
/*
this will error out with this error :
Argument of type 'User<Attributes>' is not assignable to parameter of type 'User<Attributes>[]'.
  Type 'User<Attributes>' is missing the following properties from type 'User<Attributes>[]': length, pop, push, concat, and 29 more.ts(2345)
*/
const q = new Parse.Query(MyClass).equalTo('myArrayField', u);

Closes: FILL_THIS_OUT

Approach

NonNullable assertion in equalTo/notEqualTo allows for type-level check to ignore undefined when deciding whether the field is a ParseObject or an array, allowing for normal "array contains element" type inference same as for required arrays, things like { fieldName: MyClass[] }.

Tasks

• Add tests

Summary by CodeRabbit

• Improvements

  • Improved type resolution for equalTo / notEqualTo to ignore undefined when inferring pointer vs. array-element values, tightening type safety for queries on nullable/optional attributes.

• Tests

  • Added tests exercising queries against newly declared optional array attributes (object and string arrays), validating accepted element matches and rejecting invalid element types.

[parse-github-assistant]

🚀 Thanks for opening this pull request!

❌ Please fill out all fields with a placeholder FILL_THIS_OUT. If a field does not apply to the pull request, fill in n/a or delete the line.

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Type-level updates to ParseQuery methods: equalTo and notEqualTo now use NonNullable<T['attributes'][K]> when inferring Pointer/array element types. Tests add two optional array attributes and expand type-level query tests. No runtime behavior changes.

Changes

Cohort / File(s)	Summary
ParseQuery type changes types/ParseQuery.d.ts, src/ParseQuery.ts	Updated equalTo and notEqualTo signatures to use NonNullable<T['attributes'][K]> in the conditional unions that infer ParseObject (Pointer) or array element types; purely type-level change affecting inference when attributes may be optional/nullable.
Tests — new optional array attributes types/tests.ts	Added attribute5?: AnotherSubClass[] and attribute6?: string[] to MySubClass attributes and expanded tests to validate equalTo usage for single-element and full-array matches and to assert type-safety (including negative cases) for invalid element types.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• mtrezza

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: fixing a TypeScript type error in Parse.Query.equalTo when matching optional array fields.
Description check	✅ Passed	The description is mostly complete with issue context, approach explanation, and completed tasks; however, the 'Closes' field was left empty (FILL_THIS_OUT template text).

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ae2787b) to head (259b76d).
⚠️ Report is 13 commits behind head on alpha.

Additional details and impacted files

@@            Coverage Diff            @@
##             alpha     #2901   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6235      6235           
  Branches      1481      1477    -4     
=========================================
  Hits          6235      6235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[dplewis]

@swittk That's a name I haven't seen in a while. Nice catch!

[swittk]

Hi! Nice to contribute something back once in a while 😅, life's been pretty busy but this issue's been irking me for a long time, so hopefully this helps someone else too.
I.. can't seem to find the button to edit the title of the PR though. (Edit : NVM, found it in the "classic experience" view)

[dplewis]

so hopefully this helps someone else too.

The goal of OSS and contributing

found it in the "classic experience" view

I couldn't find it either or I would have done it for you

[dplewis]

@swittk Are you just adding test cases? I see you added NonNullable and removed it, I assume nullable was the default aka optional.

[swittk]

Apologies, I forgot to commit the actual source file so when I ran to regenerate the types it simply disappeared. Should be fixed now.

[mtrezza]

Is this ready for merge?

[swittk]

Yes, I think so.

[parseplatformorg]

🎉 This change has been released in version 8.1.1-alpha.5

[parseplatformorg]

🎉 This change has been released in version 8.2.0