[swittk]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.
• Link this pull request to an issue.

Issue

Parse.Query in the old DefinitelyTyped typings used to allow for strict typings when we're doing and/or/nor operations.

Example failing case:

class MyClass extends Parse.Object<{ a: number }> {};
const q1 = new Parse.Query(MyClass).equalTo('a', 2);
const q2 = new Parse.Query(MyClass).equalTo('a', 3);
/*
In the old DefinitelyTyped typings; this would be preserved as Parse.Query<MyClass>
However, with our current typings, this loses the class typing, making it go back to ParseQuery<ParseObject<Attributes>> 
*/
const orQ = Parse.Query.or(q1, q2);

Approach

Allow for generic ParseObject subclass types to be captured & propagated in ParseQuery and/or/nor.

Tasks

• Add tests

Summary by CodeRabbit

• Refactor

  • Improved type safety for query combination operations, ensuring combined queries maintain accurate type information.

• Tests

  • Added tests to verify type preservation when combining queries.

[parse-github-assistant]

🚀 Thanks for opening this pull request!

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR introduces generic type parameters to the static or, and, and nor methods in ParseQuery, ensuring that combining typed queries of a specific ParseObject subclass returns a typed query result of that same class. This improves type safety for query composition.

Changes

Cohort / File(s)	Summary
Generic Type Parameters for Query Combinators src/ParseQuery.ts, types/ParseQuery.d.ts	Added generic type parameter T extends ParseObject to or, and, and nor static methods, updating signatures to accept ParseQuery<T>[] and return ParseQuery<T> instead of untyped ParseQuery.
Type Verification Tests types/tests.ts	Added test cases verifying that or, and, and nor preserve the class type when combining queries, confirming return types as ParseQuery<MyClass> for a custom ParseObject subclass.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• mtrezza

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description covers the issue with a code example, explains the approach to fix it, and confirms tests were added. However, it does not include a link to a related issue as required by the template.	Add a link to the related GitHub issue in the 'Closes:' field to complete the description template requirements.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: fixing TypeScript generic type preservation in Parse.Query.and/or/nor methods when combining queries.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b4156ac) to head (0c982b9).
⚠️ Report is 25 commits behind head on alpha.

Additional details and impacted files

@@            Coverage Diff            @@
##             alpha     #2903   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6235      6235           
  Branches      1493      1481   -12     
=========================================
  Hits          6235      6235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mtrezza]

Is this ready for merge?

[swittk]

I think so, yes.

[parseplatformorg]

🎉 This change has been released in version 8.1.1-alpha.1

[parseplatformorg]

🎉 This change has been released in version 8.2.0