Skip to content

fix: Type error in Parse.Query.equalTo when matching optional array #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtrezza merged 7 commits into from
Feb 11, 2026
Merged

fix: Type error in Parse.Query.equalTo when matching optional array #2901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
38428e5
added equalTo for optional arrays
swittk Feb 5, 2026
ab0b7f4
fix: Allow equalTo to match for optional arrays, regenerated types
swittk Feb 5, 2026
47eb227
fix: regenerated types after forgotten commit to ParseQuery.ts
swittk Feb 5, 2026
c6e9fb5
fix: added negative case to provide type assertion safety for optiona…
swittk Feb 5, 2026
7854185
Merge branch 'alpha' into fix-query-equalto
swittk Feb 9, 2026
41d9de7
Merge branch 'alpha' into fix-query-equalto
mtrezza Feb 10, 2026
259b76d
Merge branch 'alpha' into fix-query-equalto
mtrezza Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/ParseQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,9 +1148,9 @@ class ParseQuery<T extends ParseObject = ParseObject> {
key: K,
value:
| T['attributes'][K]
| (T['attributes'][K] extends ParseObject
| (NonNullable<T['attributes'][K]> extends ParseObject
? Pointer
: T['attributes'][K] extends (infer E)[]
: NonNullable<T['attributes'][K]> extends (infer E)[]
? E
: never)
): this {
Expand All @@ -1177,9 +1177,9 @@ class ParseQuery<T extends ParseObject = ParseObject> {
key: K,
value:
| T['attributes'][K]
| (T['attributes'][K] extends ParseObject
| (NonNullable<T['attributes'][K]> extends ParseObject
? Pointer
: T['attributes'][K] extends (infer E)[]
: NonNullable<T['attributes'][K]> extends (infer E)[]
? E
: never)
): this {
Expand Down
4 changes: 2 additions & 2 deletions types/ParseQuery.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ declare class ParseQuery<T extends ParseObject = ParseObject> {
* @param value The value that the Parse.Object must contain.
* @returns {Parse.Query} Returns the query, so you can chain this call.
*/
equalTo<K extends keyof T['attributes'] | keyof BaseAttributes>(key: K, value: T['attributes'][K] | (T['attributes'][K] extends ParseObject ? Pointer : T['attributes'][K] extends (infer E)[] ? E : never)): this;
equalTo<K extends keyof T['attributes'] | keyof BaseAttributes>(key: K, value: T['attributes'][K] | (NonNullable<T['attributes'][K]> extends ParseObject ? Pointer : NonNullable<T['attributes'][K]> extends (infer E)[] ? E : never)): this;
/**
* Adds a constraint to the query that requires a particular key's value to
* be not equal to the provided value.
Expand All @@ -426,7 +426,7 @@ declare class ParseQuery<T extends ParseObject = ParseObject> {
* @param value The value that must not be equalled.
* @returns {Parse.Query} Returns the query, so you can chain this call.
*/
notEqualTo<K extends keyof T['attributes'] | keyof BaseAttributes>(key: K, value: T['attributes'][K] | (T['attributes'][K] extends ParseObject ? Pointer : T['attributes'][K] extends (infer E)[] ? E : never)): this;
notEqualTo<K extends keyof T['attributes'] | keyof BaseAttributes>(key: K, value: T['attributes'][K] | (NonNullable<T['attributes'][K]> extends ParseObject ? Pointer : NonNullable<T['attributes'][K]> extends (infer E)[] ? E : never)): this;
/**
* Adds a constraint to the query that requires a particular key's value to
* be less than the provided value.
Expand Down
24 changes: 24 additions & 0 deletions types/tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1888,6 +1888,8 @@ function testQuery() {
attribute2: number;
attribute3: AnotherSubClass;
attribute4: string[];
attribute5?: AnotherSubClass[];
attribute6?: string[];
}> {}
const query = new Parse.Query(MySubClass);

Expand Down Expand Up @@ -1997,6 +1999,22 @@ function testQuery() {
// $ExpectType ParseQuery<MySubClass>
query.equalTo('attribute4', ['a_string_value']);


// Optional object[] (e.g. prop?: ClassName[] ): allow matching a single element (array contains object), and allow matching the full array
// $ExpectType ParseQuery<MySubClass>
query.equalTo('attribute5', new AnotherSubClass());
// $ExpectType ParseQuery<MySubClass>
query.equalTo('attribute5', [new AnotherSubClass()]);
// Since there is no `$ExpectNotError` thing, this line is instead used to at least prove that there is no regression for type safety for `Array of object` fields
// $ExpectError
query.equalTo('attribute5', new MySubClass());

// Optional string[] (e.g. prop?: string[] ): allow matching a single element (array contains string), and allow matching the full array
// $ExpectType ParseQuery<MySubClass>
query.equalTo('attribute6', 'a_string_value');
// $ExpectType ParseQuery<MySubClass>
query.equalTo('attribute6', ['a_string_value']);

// $ExpectType ParseQuery<MySubClass>
query.notEqualTo('attribute4', 'a_string_value');
// $ExpectType ParseQuery<MySubClass>
Expand All @@ -2011,6 +2029,12 @@ function testQuery() {
// $ExpectError
query.notEqualTo('attribute4', [5]);

// Optional string[]: reject invalid element types
// $ExpectError
query.equalTo('attribute6', 5);
// $ExpectError
query.notEqualTo('attribute6', 5);

// $ExpectType ParseQuery<MySubClass>
query.exists('attribute1');
// $ExpectError
Expand Down