This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add a deprecation warning to the old runtime GenesisConfig #14224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-genesisconfig-runtimegenesisconfig
juangirini
added
A3-in_progress
This was referenced May 25, 2023
Base automatically changed from
jg/14065-deprecation-genesisconfig-runtimegenesisconfig
to
master
May 26, 2023 09:42
juangirini
changed the title
juangirini
added
A0-please_review
sam0x17
approved these changes
May 26, 2023
muharem
approved these changes
May 26, 2023
|
|
sacha-l
approved these changes
May 26, 2023
michalkucharczyk
approved these changes
May 26, 2023
KiChjang
approved these changes
May 26, 2023
liamaharon
approved these changes
May 29, 2023
hummusonrails
approved these changes
May 29, 2023
kianenigma
approved these changes
Jun 14, 2023
frame/support/procedural/src/construct_runtime/expand/config.rs
Outdated
Show resolved
Hide resolved
|
bot merge |
paritytech-processbot
bot
deleted the
jg/14065-deprecation-warning-genesisconfig
branch
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…h#14224) * soft deprecate genesisconfig * temporarily add a deprecation attr * update tests * update mocks * update genesis config * update genesis config * update genesis config * update genesis config * remove deprecation warning * add a deprecation warning to the old runtime GenesisConfig * add a date to the deprecation message --------- Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to paritytech/polkadot-sdk#175
This PR adds deprecation warning when using the runtime level
GenesisConfigwhich has been renamed toRuntimeGenesisConfig.cumulus companion: paritytech/cumulus#2636
polkadot companion: paritytech/polkadot#7288