Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for Soft deprecate GenesisConfig #7288

Merged
merged 4 commits into from
Jun 16, 2023
Merged

Companion for Soft deprecate GenesisConfig #7288

merged 4 commits into from
Jun 16, 2023

Conversation

juangirini
Copy link
Contributor

@juangirini juangirini commented May 25, 2023 •
edited
Loading

@juangirini juangirini added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 25, 2023
@juangirini juangirini requested review from bkchr, sorpaas, TriplEight and a team May 25, 2023 07:59
@juangirini juangirini mentioned this pull request May 25, 2023
Merged
@juangirini juangirini added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels May 25, 2023
@juangirini juangirini changed the title Companion for Soft deprecate GenesisConfig [WIP] Companion for Soft deprecate GenesisConfig May 25, 2023
@juangirini juangirini mentioned this pull request May 25, 2023
Merged
@sam0x17 sam0x17 self-requested a review May 25, 2023 12:40
acatangiu
acatangiu previously approved these changes May 25, 2023
View reviewed changes
@acatangiu acatangiu dismissed their stale review May 25, 2023 12:42

accidental button smash

@juangirini juangirini changed the title [WIP] Companion for Soft deprecate GenesisConfig Companion for Soft deprecate GenesisConfig May 26, 2023
parity-processbot added 2 commits June 16, 2023 10:54
@paritytech-processbot
Copy link

Waiting for commit status.

@juangirini
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 48bbf36 into master Jun 16, 2023
@paritytech-processbot paritytech-processbot bot deleted the jg/14065-companion-for-deprecation-genesisconfig-runtimegenesisconfig branch June 16, 2023 11:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

@KiChjang KiChjang KiChjang approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

@acatangiu acatangiu acatangiu left review comments

@sorpaas sorpaas Awaiting requested review from sorpaas

@TriplEight TriplEight Awaiting requested review from TriplEight

Assignees
No one assigned
Labels
A3-in_progress Pull request is in progress. No review needed at this stage. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@juangirini @sam0x17 @KiChjang @bkchr @ggwpez @acatangiu