[Deprecation] GenesisConfig -> RuntimeGenesisConfig

[kianenigma]

We renamed many of the composite enums such that the outer one is called RuntimeXXX eg paritytech/substrate#11981, but we seem to have missed this one.

Like other deprecations, we should keep the old name, but mark its usage is deprecated eg #182

Deprecation steps

Beta Give feedback

1. Soft deprecation and removal from the codebase Soft deprecate GenesisConfig substrate#14210
2. Update examples and tutorials Update examples and tutorials mentioning GenesisConfig polkadot-developers/substrate-docs#1996
3. Hard deprecation by adding a deprecate compiler warning Add a deprecation warning to the old runtime GenesisConfig substrate#14224
4. Deprecation is noted in the release log
5. Removal version is planned -> after 16 Dec
6. Deprecated feature is removed from the code base
7. Removal of the feature is noted in the release log

[philoniare]

@kianenigma can I take this one? Just to clarify, the task involves:

• removing GenesisConfig as it has already been soft deprecated until Dec 2023
• updating all pallets that use GenesisConfig to RuntimeGenesisConfig

Did I miss anything?

[kianenigma]

Yes, you should fully remove

polkadot-sdk/substrate/frame/support/procedural/src/construct_runtime/expand/config.rs

Line 81 in 878c562

pub type GenesisConfig = RuntimeGenesisConfig;

and fix any issues, which I don't think will be that many.

[RomarQ]

@kianenigma I created #3378 for removing the GenesisConfig deprecated type, the changes were minimal.

If I missed something, please let me know.

[philoniare]

@RomarQ I believe you should be updating GenesisConfig to RuntimeGenesisConfig in pallets as well. There's quite a few pallets that still use GenesisConfig, so you'll need to update those. I've taken a quick look and identified the below:

system
aura
assets
babe
beefy
broker
glutton
grandpa
indices
lottery
mixnet
nfts
nis
salary
benchmarking
society
staking
sudo
treasury

[RomarQ]

@RomarQ I believe you should be updating GenesisConfig to RuntimeGenesisConfig in pallets as well. There's quite a few pallets that still use GenesisConfig, so you'll need to update those. I've taken a quick look and identified the below:

system
aura
assets
babe
beefy
broker
glutton
grandpa
indices
lottery
mixnet
nfts
nis
salary
benchmarking
society
staking
sudo
treasury

No, there is no point in renaming the struct in these pallets to RuntimeGenesisConfig. The change was specific to the deprecated type, which was removed in the PR mentioned above.

Also, just to give more context, the pallet::genesis_config macro enforces the name to be GenesisConfig.

if ident != "GenesisConfig" {
	let msg = "Invalid pallet::genesis_config, ident must `GenesisConfig`";
	return Err(syn::Error::new(ident.span(), msg))
}