Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Re-enable metadata compare CI check #3895

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Re-enable metadata compare CI check #3895

merged 1 commit into from
Sep 20, 2021

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Sep 20, 2021

@jacogr jacogr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 20, 2021
@ordian
Copy link
Member

ordian commented Sep 20, 2021

https://gitlab.parity.io/parity/polkadot/-/jobs/1128287

Error: PortableRegistry: Unable to find type with lookupId 298
at assert (/usr/local/lib/node_modules/@polkadot/metadata-cmp/node_modules/@polkadot/util/assert.cjs:34:11)
at Map.getSiType (/usr/local/lib/node_modules/@polkadot/metadata-cmp/node_modules/@polkadot/types/generic/PortableRegistry.cjs:291:22)
at /usr/local/lib/node_modules/@polkadot/metadata-cmp/compare.cjs:168:86
at Array.forEach ()
at /usr/local/lib/node_modules/@polkadot/metadata-cmp/compare.cjs:149:36
at Array.forEach ()
at main (/usr/local/lib/node_modules/@polkadot/metadata-cmp/compare.cjs:97:34)
at processTicksAndRejections (node:internal/process/task_queues:94:5)
at runNextTicks (node:internal/process/task_queues:63:3)
at processImmediate (node:internal/timers:437:9)

@jacogr
Copy link
Contributor Author

jacogr commented Sep 20, 2021

The above is worrying .... need to have a look, replicate (have not been able to do so when testing) and fix before this goes in.

@jacogr jacogr mentioned this pull request Sep 20, 2021
Merged
@jacogr
Copy link
Contributor Author

jacogr commented Sep 20, 2021 •
edited
Loading

Sorry for the run-about, it should be fixed after https://github.com/polkadot-js/tools/releases/tag/v0.46.2 (at least could replicate a similar issue isn some cases, this is not fixed in the latest package release)

TL;DR A trigger of the job should now do the trick..

@ordian
Copy link
Member

ordian commented Sep 20, 2021

https://gitlab.parity.io/parity/polkadot/-/jobs/1129384
other than

API/INIT: RPC methods not decorated: childstate_getStorageEntries

it looks good now 👍

@jacogr
Copy link
Contributor Author

jacogr commented Sep 20, 2021

Yes, the above is logged at polkadot-js/api#3978 - it seems I missed that PR in substrate. (The warning it there as a reminder that it should be done, rather than it is broken because it doesn't have it)

@ordian ordian merged commit e0a53cf into master Sep 20, 2021
@ordian ordian deleted the jg-metadata-cmp branch September 20, 2021 15:20
@xlc xlc mentioned this pull request Sep 20, 2021
Closed
ordian added a commit that referenced this pull request Sep 21, 2021
@ordian
Merge branch 'master' into temporary-malus
8679c5e 
* master:
  weights: pallet-staking & pallet-bags-list (#3872)
  Re-enable metadata compare CI check (#3895)
  Bump `parity-util-mem` to 0.10.2 (#3897)
  Revert "remove connected disconnected state only (#3868)" (#3896)
  Companion for Generate storage info for pallet im_online #9654 (#3744)
  Gather memory usage statistics through `parity-util-mem` (#3893)
  ci: cache seed in fuzzer job (#3885)
  Add benchmarking for parachain runtime configuration pallet (#3862)
  Run fmt (#3887)
  remove connected disconnected state only (#3868)
  Dispute distribution improvements (#3853)
  Companion for Store voters in unsorted bags to get good stake iteration properties (#3413)
  Add info logging to dispute activation (#3870)
  update Rococo.json (#3871)
  Companion for #9764 (Force Unreserve) (#3840)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bring back check-transaction-versions
2 participants
@jacogr @ordian