This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Companion for Generate storage info for pallet im_online #9654 #3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
added
A0-please_review
KiChjang
approved these changes
Sep 19, 2021
|
@georgesdib Do you mind cherry-picking your commits off to another branch instead of working on top of master? I think our CI bot is unable to build this PR due to different master commit histories of your repo vs ours. |
`MaxPeerDataEncodingSize` to paller `im_online` after substrate changes
|
@KiChjang I have rebased and committed from scratch, hope this solves the issue |
|
Waiting for commit status. |
|
Merge aborted: Checks failed for 75d1299 |
|
bot merge |
|
Trying merge. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Sep 20, 2021
* master: Bump `parity-util-mem` to 0.10.2 (#3897) Revert "remove connected disconnected state only (#3868)" (#3896) Companion for Generate storage info for pallet im_online #9654 (#3744) Gather memory usage statistics through `parity-util-mem` (#3893) ci: cache seed in fuzzer job (#3885) Add benchmarking for parachain runtime configuration pallet (#3862) Run fmt (#3887) remove connected disconnected state only (#3868)
ordian
added a commit
that referenced
this pull request
Sep 21, 2021
* master: weights: pallet-staking & pallet-bags-list (#3872) Re-enable metadata compare CI check (#3895) Bump `parity-util-mem` to 0.10.2 (#3897) Revert "remove connected disconnected state only (#3868)" (#3896) Companion for Generate storage info for pallet im_online #9654 (#3744) Gather memory usage statistics through `parity-util-mem` (#3893) ci: cache seed in fuzzer job (#3885) Add benchmarking for parachain runtime configuration pallet (#3862) Run fmt (#3887) remove connected disconnected state only (#3868) Dispute distribution improvements (#3853) Companion for Store voters in unsorted bags to get good stake iteration properties (#3413) Add info logging to dispute activation (#3870) update Rococo.json (#3871) Companion for #9764 (Force Unreserve) (#3840)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to paritytech/substrate#9654
Adding
MaxKeys,MaxPeerInHeartbeatsandMaxPeerIdEncodingSizeto pallet im_online@shawntabrizi @KiChjang @thiolliere