[Staking] [AHM] Fixes insufficient slashing of nominators (and some other small issues).#8937
Merged
[Staking] [AHM] Fixes insufficient slashing of nominators (and some other small issues).#8937
Conversation
Ank4n
added
R0-no-crate-publish-required
Ank4n
changed the title
Ank4n
removed
the
R0-no-crate-publish-required
Contributor
Author
|
/cmd prdoc --audience runtime_dev |
Ank4n
changed the title
kianenigma
reviewed
Jun 30, 2025
kianenigma
reviewed
Jun 30, 2025
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
Changes and the test looks good, I will approve once I learn more about the motivation behind slashing change.
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
sigurpol
approved these changes
Jul 1, 2025
Contributor
sigurpol
left a comment
sigurpol
left a comment
There was a problem hiding this comment.
I'm not familiar with all the slashing magic, but the changes and tests make sense to me, so I give a weak approval 😄
kianenigma
approved these changes
Jul 1, 2025
ordian
added a commit
that referenced
this pull request
Jul 24, 2025
* master: (91 commits) Add extra information to the harmless error logs during validate_transaction (#9047) `sp-tracing`: Remove `test-utils` feature (#9063) add try-state check for staking roles -- staker cannot be nominator a… (#9034) net/discovery: File persistence for `AddrCache` (#8839) dispute-coordinator: handle race with offchain disabling (#9050) Align parameters for `EventEmitter::emit_sent_event` (#9057) Fetch parent block `api_version` (#9059) [XCM Precompile] Rename functions and improve docs in the Solidity interface (#9023) Cleanup and improvements for `ControlledValidatorIndices` (#8896) reenable 0001-parachains-pvf (#9046) Add optional auto-rebag within on-idle (#8684) Fix flaxy 0003-block-building-warp-sync test - one more approach (#8974) [Staking] [AHM] Fixes insufficient slashing of nominators (and some other small issues). (#8937) chore: Bump bounded-collections dep (#9004) XCMP and DMP improvements (#8860) EPMB/unsigned: fixed multi-page winner computation (#8987) Always send full parent header, not only hash, part of collation response (#8939) revive: Precompiles should return dummy code when queried (#9001) Fix confusing log messages in network protocol behaviour (#8819) Fix pallet_migrations benchmark when FailedMigrationHandler emits events (#8694) ...
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
…ther small issues). (#8937) Changes to pallet-staking-async ## Removed - Config constant `MaxDisabledValidators`: This constant was removed since validator disabling logic has been moved to pallet-session, making it redundant in staking-async. - Storage DoubleMap `NominatorSlashInEra`: This was used to track per-era maximum slashes for nominators. It’s no longer required — we now only track the highest slash per validator per era. - Call `withdraw_overstake`: This was a temporary extrinsic meant to fix overstake issues, but with fungible migration of staking funds, this is no longer possible and the extrinsic is obsolete. ## Changed - Nominator slashing logic: The logic now aggregates slashes from distinct offending validators nominated by a nominator within the same era. For repeated offences by the same validator, only the highest slash fraction is applied. Previously, the pallet applied only the highest slash across all validators, regardless of how many were slashed. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to pallet-staking-async
Removed
MaxDisabledValidators: This constant was removed since validator disabling logic has been moved to pallet-session, making it redundant in staking-async.NominatorSlashInEra: This was used to track per-era maximum slashes for nominators. It’s no longer required — we now only track the highest slash per validator per era.withdraw_overstake: This was a temporary extrinsic meant to fix overstake issues, but with fungible migration of staking funds, this is no longer possible and the extrinsic is obsolete.Changed