XCMP and DMP improvements#8860

Merged

serban300 merged 22 commits intoparitytech:masterfrom

serban300:message-passing-adjustments

Jul 1, 2025

Contributor

serban300 commented Jun 16, 2025 •

edited

Loading

Related to #489

This PR changes the parachain receiving logic for XCMP and DMP by adding some offchain processing before forwarding the messages to the parachain set_validation_data inherent. This enables us to relax the advancement rule.

serban300 self-assigned this

serban300 added T9-cumulus T18-zombienet_tests labels

serban300 force-pushed the message-passing-adjustments branch 5 times, most recently from b65eafa to ae8fcc5 Compare

June 16, 2025 11:23

serban300 requested review from acatangiu, bkchr, ggwpez and seadanda

June 16, 2025 13:53

ggwpez reviewed

View reviewed changes

cumulus/pallets/parachain-system/src/lib.rs Outdated Show resolved Hide resolved

serban300 changed the title ~~[WIP] XCMP and DMP improvements~~ XCMP and DMP improvements

ggwpez reviewed

View reviewed changes

cumulus/pallets/parachain-system/src/lib.rs Show resolved Hide resolved

serban300 force-pushed the message-passing-adjustments branch from ae8fcc5 to c1811ae Compare

June 16, 2025 16:15

serban300 added 3 commits

June 20, 2025 12:14


          XCMP and DMP improvements

fef3e08

Perform some offchain processing for the XCMP and DMP messages before
forwarding them to the parachain `set_validation_data` inherent.


          prdoc

a071ec0


          Docs

f797f1c

serban300 force-pushed the message-passing-adjustments branch from 3ee5165 to f797f1c Compare

June 20, 2025 09:14

bkchr reviewed

View reviewed changes

Member

bkchr left a comment

Generally looking good. Though, left comments on a lot of things :)

polkadot/runtime/parachains/src/hrmp.rs Show resolved Hide resolved

cumulus/primitives/parachain-inherent/src/lib.rs Outdated Show resolved Hide resolved

cumulus/pallets/parachain-system/src/lib.rs Outdated Show resolved Hide resolved

cumulus/pallets/parachain-system/src/lib.rs Outdated Show resolved Hide resolved

cumulus/pallets/parachain-system/src/lib.rs Outdated Show resolved Hide resolved

cumulus/primitives/parachain-inherent/src/lib.rs Outdated Show resolved Hide resolved

cumulus/pallets/parachain-system/src/lib.rs Show resolved Hide resolved

cumulus/pallets/parachain-system/src/lib.rs Outdated Show resolved Hide resolved

cumulus/pallets/parachain-system/src/lib.rs Show resolved Hide resolved

cumulus/primitives/parachain-inherent/src/lib.rs Outdated Show resolved Hide resolved

serban300 added 5 commits

June 24, 2025 16:02


          CR comments

9c77a98


          Merge remote-tracking branch 'upstream/master' into message-passing-a…

de04f73

…djustments


          Fix CI

e65f933


          fix prdoc

e9e98d6


          Merge remote-tracking branch 'upstream/master' into message-passing-a…

8308fca

…djustments

bkchr reviewed

View reviewed changes

Member

bkchr left a comment

Generally looking good. There are still a lot of missing docs for public methods.

cumulus/primitives/parachain-inherent/src/lib.rs Outdated Show resolved Hide resolved

polkadot/core-primitives/src/lib.rs Outdated Show resolved Hide resolved

polkadot/node/subsystem-util/src/inclusion_emulator/mod.rs Show resolved Hide resolved

cumulus/pallets/parachain-system/src/lib.rs Show resolved Hide resolved

cumulus/pallets/parachain-system/src/lib.rs Outdated Show resolved Hide resolved

cumulus/pallets/parachain-system/src/lib.rs Outdated Show resolved Hide resolved

cumulus/pallets/parachain-system/src/lib.rs Outdated Show resolved Hide resolved

cumulus/primitives/parachain-inherent/src/lib.rs Outdated Show resolved Hide resolved

cumulus/primitives/parachain-inherent/src/lib.rs Outdated Show resolved Hide resolved

polkadot/core-primitives/src/lib.rs Outdated Show resolved Hide resolved

acatangiu requested a review from alindima

June 25, 2025 15:06

serban300 added 2 commits

June 25, 2025 20:51


          CR comments

5f614e2

fix

6ecd1be

serban300 added a commit to serban300/polkadot-sdk that referenced this pull request


          Backport paritytech#8860

613d350

Related to paritytech#489

This PR changes the parachain receiving logic for XCMP and DMP by adding
some offchain processing before forwarding the messages to the parachain
`set_validation_data` inherent. This enables us to relax the advancement
rule.

serban300 mentioned this pull request

[Draft][stable2506] Partially backport #8860 #9192

Closed

redzsina moved this from Scheduled to In progress in Security Audit (PRs) - SRLabs

serban300 added the A4-backport-stable2506 label

paritytech-release-backport-bot bot pushed a commit that referenced this pull request


          XCMP and DMP improvements (#8860)

84553b6

Related to #489

This PR changes the parachain receiving logic for XCMP and DMP by adding
some offchain processing before forwarding the messages to the parachain
`set_validation_data` inherent. This enables us to relax the advancement
rule.

(cherry picked from commit a51c312)

paritytech-release-backport-bot bot mentioned this pull request

[stable2506] Backport #8860 relay chain logic (runtime + client) #9193

Merged

paritytech-release-backport-bot bot commented Jul 14, 2025

Successfully created backport PR for stable2506:

[stable2506] Backport #8860 relay chain logic (runtime + client) #9193

serban300 added a commit that referenced this pull request


          [stable2506] Backport #8860 relay chain logic (runtime + client) (#9193)

fcdb807

Backport #8860 relay chain logic (runtime + client) into `stable2506` from serban300.

This PR backports the relay chain client and runtime changes related to
#8860.

This way we could start relaxing the advancement rule on the relay
chain, and in a future release we will introduce the new parachain
runtime logic.

---------

Co-authored-by: Serban Iorga <serban@parity.io>
Co-authored-by: Serban Iorga <serban300@gmail.com>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

ordian added a commit that referenced this pull request


          Merge branch 'master' into ao-fix-issue-64

5cd6006

* master: (91 commits)
  Add extra information to the harmless error logs during validate_transaction (#9047)
  `sp-tracing`: Remove `test-utils` feature (#9063)
  add try-state check for staking roles -- staker cannot be nominator a… (#9034)
  net/discovery: File persistence for `AddrCache` (#8839)
  dispute-coordinator: handle race with offchain disabling (#9050)
  Align parameters for `EventEmitter::emit_sent_event` (#9057)
  Fetch parent block `api_version` (#9059)
  [XCM Precompile] Rename functions and improve docs in the Solidity interface (#9023)
  Cleanup and improvements for `ControlledValidatorIndices` (#8896)
  reenable 0001-parachains-pvf (#9046)
  Add optional auto-rebag within on-idle (#8684)
  Fix flaxy 0003-block-building-warp-sync test - one more approach (#8974)
  [Staking] [AHM] Fixes insufficient slashing of nominators (and some other small issues). (#8937)
  chore: Bump bounded-collections dep (#9004)
  XCMP and DMP improvements (#8860)
  EPMB/unsigned: fixed multi-page winner computation (#8987)
  Always send full parent header, not only hash, part of collation response (#8939)
  revive: Precompiles should return dummy code when queried (#9001)
  Fix confusing log messages in network protocol behaviour (#8819)
  Fix pallet_migrations benchmark when FailedMigrationHandler emits events (#8694)
  ...

serban300 mentioned this pull request

[HRMP] Check messages order before enqueing them #9326

Merged

github-merge-queue bot pushed a commit that referenced this pull request


          [HRMP] Check messages order before enqueing them (#9326)

bd78cc5

Related to #8860

This PR adds a check in order to ensure that the collator has respected
the proper order when sending the HRMP messages to the runtime.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andrii <ndk@parity.io>

paritytech-release-backport-bot bot pushed a commit that referenced this pull request


          [HRMP] Check messages order before enqueing them (#9326)

044a335

Related to #8860

This PR adds a check in order to ensure that the collator has respected
the proper order when sending the HRMP messages to the runtime.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andrii <ndk@parity.io>
(cherry picked from commit bd78cc5)

redzsina moved this from In progress to Waiting for fix in Security Audit (PRs) - SRLabs

serban300 mentioned this pull request

[Tracking issue] Message passing mechanisms improvements #8308

Closed

4 tasks

alvicsam pushed a commit that referenced this pull request


          XCMP and DMP improvements (#8860)

b4e6759

Related to #489

This PR changes the parachain receiving logic for XCMP and DMP by adding
some offchain processing before forwarding the messages to the parachain
`set_validation_data` inherent. This enables us to relax the advancement
rule.

alvicsam pushed a commit that referenced this pull request


          Improve pr_8860.prdoc (#9171)

77f04de

Improved PR doc for #8860

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Adrian Catangiu <adrian@parity.io>

alvicsam pushed a commit that referenced this pull request


          [HRMP] Check messages order before enqueing them (#9326)

37b6a21

Related to #8860

This PR adds a check in order to ensure that the collator has respected
the proper order when sending the HRMP messages to the runtime.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andrii <ndk@parity.io>

github-merge-queue bot pushed a commit that referenced this pull request


          Make HRMP advancement rule more restrictive (#9086)

e30ff0d

Related to: #9021
Followup for #8860

Looked some more into this and from what I understand the HRMP max
message size can't be changed dynamically. In order to change it we
would need to close the channel and than open it again which would lead
to clearing all the pending messages. So it's safe to use the current
hrmp max message size in the advancement rule check.

manuelmauro mentioned this pull request

Upgrade Moonbeam to Polkadot SDK stable2512 moonbeam-foundation/moonbeam#3633

Open

pgherveou added this to [preview] release tracker

github-project-automation bot moved this to Todo in [preview] release tracker

github-project-automation bot moved this from Todo to Done in [preview] release tracker

pgherveou removed this from [preview] release tracker

pgherveou added this to [preview] release tracker

github-project-automation bot moved this to Todo in [preview] release tracker

github-project-automation bot moved this from Todo to Done in [preview] release tracker

pgherveou removed this from [preview] release tracker

pgherveou added this to [preview] release tracker

github-project-automation bot moved this to Todo in [preview] release tracker

github-project-automation bot moved this from Todo to Done in [preview] release tracker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A4-backport-stable2506 T9-cumulus T18-zombienet_tests