Fix confusing log messages in network protocol behaviour#8819
Merged
bkchr merged 2 commits intoparitytech:masterfrom Jun 30, 2025
Merged
Fix confusing log messages in network protocol behaviour#8819bkchr merged 2 commits intoparitytech:masterfrom
bkchr merged 2 commits intoparitytech:masterfrom
Conversation
bkchr
approved these changes
Jun 30, 2025
bkchr
added
the
R0-no-crate-publish-required
alexggh
approved these changes
Jun 30, 2025
dmitry-markin
approved these changes
Jun 30, 2025
Contributor
|
@bkchr is |
Merged
via the queue into
paritytech:master
with commit Jun 30, 2025
0bd8457
275 of 315 checks passed
ordian
added a commit
that referenced
this pull request
Jul 24, 2025
* master: (91 commits) Add extra information to the harmless error logs during validate_transaction (#9047) `sp-tracing`: Remove `test-utils` feature (#9063) add try-state check for staking roles -- staker cannot be nominator a… (#9034) net/discovery: File persistence for `AddrCache` (#8839) dispute-coordinator: handle race with offchain disabling (#9050) Align parameters for `EventEmitter::emit_sent_event` (#9057) Fetch parent block `api_version` (#9059) [XCM Precompile] Rename functions and improve docs in the Solidity interface (#9023) Cleanup and improvements for `ControlledValidatorIndices` (#8896) reenable 0001-parachains-pvf (#9046) Add optional auto-rebag within on-idle (#8684) Fix flaxy 0003-block-building-warp-sync test - one more approach (#8974) [Staking] [AHM] Fixes insufficient slashing of nominators (and some other small issues). (#8937) chore: Bump bounded-collections dep (#9004) XCMP and DMP improvements (#8860) EPMB/unsigned: fixed multi-page winner computation (#8987) Always send full parent header, not only hash, part of collation response (#8939) revive: Precompiles should return dummy code when queried (#9001) Fix confusing log messages in network protocol behaviour (#8819) Fix pallet_migrations benchmark when FailedMigrationHandler emits events (#8694) ...
tmpolaczyk
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Oct 16, 2025
…8819) # Description This PR fixes confusing trace log messages in the substrate client network behavior code. ## Integration These log messages can be merged into existing logging code, or the changes can be safely ignored. ## Review Notes When the node logs: > Will start to connect at until Instant It is unclear if connections will start at the instant, or will occur until the instant. This PR deletes "until" to make the message match the behaviour in the code. There's also a minor grammar fix in another trace message. # Checklist * [ ] My PR follows the [labeling requirements]( https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md#Process ) of this project (at minimum one label for `T` required) * External contributors: ask maintainers to put the right label on your PR. Please add the label T0-node to this PR. Co-authored-by: Bastian Köcher <git@kchr.de>
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
# Description This PR fixes confusing trace log messages in the substrate client network behavior code. ## Integration These log messages can be merged into existing logging code, or the changes can be safely ignored. ## Review Notes When the node logs: > Will start to connect at until Instant It is unclear if connections will start at the instant, or will occur until the instant. This PR deletes "until" to make the message match the behaviour in the code. There's also a minor grammar fix in another trace message. # Checklist * [ ] My PR follows the [labeling requirements]( https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md#Process ) of this project (at minimum one label for `T` required) * External contributors: ask maintainers to put the right label on your PR. Please add the label T0-node to this PR. Co-authored-by: Bastian Köcher <git@kchr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes confusing trace log messages in the substrate client network behavior code.
Integration
These log messages can be merged into existing logging code, or the changes can be safely ignored.
Review Notes
When the node logs:
It is unclear if connections will start at the instant, or will occur until the instant.
This PR deletes "until" to make the message match the behaviour in the code.
There's also a minor grammar fix in another trace message.
Checklist
Trequired)Please add the label T0-node to this PR.