Create E2E tests for nomination pools #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, remove PAPI, as it was not possible to submit transactions using it.
Collaborator
Author
xlc
reviewed
Jan 28, 2025
packages/polkadot/src/__snapshots__/polkadotNominationPools.e2e.test.ts.snap
Outdated
Show resolved
Hide resolved
|
|
||
| /// Process events | ||
|
|
||
| const events = await relayClient.api.query.system.events() |
Member
There was a problem hiding this comment.
this is not really needed because the snapshot above already assets everything including the error type
Collaborator
Author
There was a problem hiding this comment.
You're correct; however, the reason I left this section here is that the snapshot is just
"dispatchError": {
"Module": {
"error": "0x08000000",
"index": 41,
},
},whereas in assert(relayClient.api.errors.nominationPools.MinimumBondNotMet.is(dispatchError.asModule)), the semantic value of the error/index from above is explicitly verified.
If I were introduced to this repository, to this test case, and then shown the snapshot, I would be slightly confused by the meaning of 0x08000000/41.
Also, remove some time-dependente information from snapshots - pool IDs.
xlc
approved these changes
Jan 28, 2025
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Feb 4, 2025
Found via open-web3-stack/polkadot-ecosystem-tests#165. Closes #7370 . # Description Some extrinsics from `pallet_nomination_pools` were not emitting events: * `set_configs` * `set_claim_permission` * `set_metadata` * `chill` * `nominate` ## Integration N/A ## Review Notes N/A --------- Co-authored-by: Ankan <[email protected]>
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Feb 4, 2025
Found via open-web3-stack/polkadot-ecosystem-tests#165. Closes #7370 . # Description Some extrinsics from `pallet_nomination_pools` were not emitting events: * `set_configs` * `set_claim_permission` * `set_metadata` * `chill` * `nominate` ## Integration N/A ## Review Notes N/A --------- Co-authored-by: Ankan <[email protected]>
Merged
This was referenced Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #63 and #115, this PR adds E2E tests to nomination pool functionality.
This is enough to get started and cover basic user journeys; more can gradually be built from here.