migrate zombie past slashing test #7147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepoviola
reviewed
Jan 14, 2025
* master: (33 commits) Implement `pallet-asset-rewards` (#3926) [pallet-revive] Add host function `to_account_id` (#7091) [pallet-revive] Remove revive events (#7164) [pallet-revive] Remove debug buffer (#7163) litep2p: Provide partial results to speedup GetRecord queries (#7099) [pallet-revive] Bump asset-hub westend spec version (#7176) Remove 0 as a special case in gas/storage meters (#6890) [pallet-revive] Fix `caller_is_root` return value (#7086) req-resp/litep2p: Reject inbound requests from banned peers (#7158) Add "run to block" tools (#7109) Fix reversed error message in DispatchInfo (#7170) approval-voting: Make importing of duplicate assignment idempotent (#6971) Parachains: Use relay chain slot for velocity measurement (#6825) PRDOC: Document `validate: false` (#7117) xcm: convert properly assets in xcmpayment apis (#7134) CI: Only format umbrella crate during umbrella check (#7139) approval-voting: Fix sending of assignments after restart (#6973) Retry approval on availability failure if the check is still needed (#6807) [pallet-revive-eth-rpc] persist eth transaction hash (#6836) litep2p: Sufix litep2p to the identify agent version for visibility (#7133) ...
This reverts commit 18f6580.
* master: (58 commits) [pallet-revive] pack exceeding syscall arguments into registers (#7319) cumulus: bump PARENT_SEARCH_DEPTH and add test for 12-core elastic scaling (#6983) xcm: fix for DenyThenTry Barrier (#7169) Migrating polkadot-runtime-common slots benchmarking to v2 (#6614) Add development chain-spec file for minimal/parachain templates for Omni Node compatibility (#6529) `Arc` definition in `TransactionPool` (#7042) [sync] Let new subscribers know about already connected peers (backward-compatible) (#7344) Removed unused dependencies (partial progress) (#7329) Improve debugging by using `#[track_caller]` in system `assert_last_event` and `assert_has_event` (#7142) `set_validation_data` register weight manually, do not use refund when the pre dispatch is zero. (#7327) Fix the link to the chain snapshots (#7330) revive: Fix compilation of `uapi` crate when `unstable-hostfn` is not set (#7318) [pallet-revive] eth-rpc minor fixes (#7325) sync-templates: enable syncing from stable release patches (#7227) Bridges: emulated tests small nits/improvements (#7322) fix(cmd bench-omni): build omni-bencher with production profile (#7299) Nits for collectives-westend XCM benchmarks setup (#7215) bench all weekly - and fix for pallet_multisig lib (#6789) Deprecate ParaBackingState API (#6867) Fix setting the image properly (#7315) ...
* master: Remove warnings by cleaning up the `Cargo.toml` (#7416) [Backport] Version bumps from stable2412-1 + prdocs reorg (#7401) fix pre-dispatch PoV underweight for ParasInherent (#7378) malus-collator: implement malicious collator submitting same collation to all backing groups (#6924) `fatxpool`: use tracing for logging (#6897) Improvements for Weekly bench (#7390) Replace derivative dependency with derive-where (#7324) Add support for feature `pallet_balances/insecure_zero_ed` in benchmarks and testing (#7379) Fix Snowbridge benchmark tests (#7296) Bridges small nits/improvements (#7383) Migrating cumulus-pallet-session-benchmarking to Benchmarking V2 (#6564) [pallet-revive] implement the block author API (#7198) Use checked math in frame-balances named_reserve (#7365) move installation of frame-omni-bencher into a cmd.py itself (#7372) remove old bench & revert the frame-weight-template (#7362) ci: fix workflow permissions (#7366) [net/libp2p] Use raw `Identify` observed addresses to discover external addresses (#7338) Improve `set_validation_data` error message. (#7359) Implement pallet view function queries (#4722)
ordian
added
T10-tests
tdimitrov
approved these changes
Feb 6, 2025
| .ok_or(anyhow::anyhow!("Can't get finalized block from stream"))?? | ||
| .number(); | ||
| sleep(Duration::from_secs(12)).await; | ||
| let second_measurement = finalized_blocks |
Contributor
There was a problem hiding this comment.
Sorry for being hypocritical as I have written such checks in my tests as well but if the finality has stalled won't we block here forever (or at least when a new block is finalized)?
Contributor
Author
There was a problem hiding this comment.
Yeah, I wasn't sure about sprinkling timeouts everywhere, but added a timeout on the call site as it makes sense.
Comment on lines
40
to
42
| "lookahead": 2, | ||
| "max_candidate_depth": 3, | ||
| "allowed_ancestry_len": 2 |
Contributor
There was a problem hiding this comment.
I think the parameters should be modified a little:
- We are in the process of bumping
lookaheadto 3 on Kusama (done) and Polkadot (will be done soon). The etst networks also use lookahead=3 (bump lookahead to 3 for testnet genesis #7252). I think it's better to set it to 3 here too. - With deprecate AsyncBackingParams #7254 we shouldn't need
max_candidate_depthandallowed_ancestry_len.
Also in the old test group_rotation_frequency was 2 but I believe you did it on purpose?
Contributor
Author
There was a problem hiding this comment.
Also in the old test group_rotation_frequency was 2 but I believe you did it on purpose?
Bumped it to make sure malus doesn't miss it's backing slot(s) due to flakyness/slowness in CI setup. It needs to be low enough OTOH that malus gets assigned quickly.
| }) | ||
| }) | ||
| .with_parachain(|p| { | ||
| p.with_id(1337) |
This PR ensures that litep2p will keep an idle connection alive for 10 seconds. The bump from 5 seconds is done to mirror the libp2p behavior and potentially improve connection stability: https://github.com/paritytech/polkadot-sdk/blob/a07fb323bc0cfb5c2fb4c8fbe9d20e344cc8eeaf/substrate/client/network/src/service.rs#L542-L549 cc @paritytech/networking --------- Signed-off-by: Alexandru Vasile <[email protected]>
alindima
reviewed
Feb 7, 2025
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
alindima
approved these changes
Feb 12, 2025
AndWeHaveAPlan
approved these changes
Feb 12, 2025
clangenb
pushed a commit
to clangenb/polkadot-sdk
that referenced
this pull request
Feb 19, 2025
to zombienet-sdk 0.2.24 (also needed to update to this version for slashing to work). --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: Alexandru Vasile <[email protected]>
This was referenced Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to zombienet-sdk 0.2.24 (also needed to update to this version for slashing to work).