Skip to content

Fix penpal runtime & enable zombienet tests again. #10667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eskimor wants to merge 3 commits into from
Closed

Fix penpal runtime & enable zombienet tests again. #10667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ee72f8
Fix penpal runtime & enable zombienet tests again.
eskimor Dec 16, 2025
a54ce4b
Fund well known accounts.
eskimor Dec 16, 2025
8222ba9
Add back some flaky tests.
eskimor Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/zombienet-flaky-tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ zombienet-substrate-0002-validators-warp-sync:8871
zombienet-cumulus-0009-elastic_scaling_pov_recovery:8986
zombienet-cumulus-0010-elastic_scaling_multiple_block_per_slot:8999
zombienet-polkadot-functional-0014-chunk-fetching-network-compatibility:9980
# disabled until zombienet support penpal (https://github.com/paritytech/zombienet-sdk/issues/480)
zombienet-polkadot-shared-core-idle-parachain:10653
zombienet-polkadot-functional-async-backing-6-seconds-rate:10653
Copy link
Copy Markdown
Contributor

@pepoviola pepoviola Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eskimor / @sandreim, can we remove this test according to #10654 (comment)

wdyt?

Copy link
Copy Markdown
Contributor

@sandreim sandreim Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

async backing should be fine to remove, but not so sure about core sharing.

zombienet-polkadot-elastic-scaling-doesnt-break-parachains:10653
zombienet-polkadot-smoke-0005-precompile-pvf-smoke:10653
zombienet-polkadot-smoke-0004-coretime-smoke-test:10653
zombienet-polkadot-smoke-0002-parachains-parachains-upgrade-smoke:10653
Copy link
Copy Markdown
Contributor

@pepoviola pepoviola Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eskimor / @sandreim, can we remove this test according to this comment #10654 (comment)
wdyt?

Copy link
Copy Markdown
Contributor

@sandreim sandreim Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

zombienet-polkadot-smoke-0004-coretime-smoke-test:10653
8 changes: 3 additions & 5 deletions cumulus/parachains/runtimes/testing/penpal/src/genesis_config_presets.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,9 @@ fn penpal_parachain_genesis(
"pal-2".as_bytes().to_vec(),
12,
)],
accounts: vec![(
crate::xcm_config::TELEPORTABLE_ASSET_ID,
sudo.clone(),
crate::EXISTENTIAL_DEPOSIT * 4096,
)]
// Don't pre-fund accounts with non-sufficient assets at genesis
// They can be minted later if needed
accounts: vec![]
Comment on lines +87 to +89
Copy link
Copy Markdown
Contributor

@pepoviola pepoviola Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are making a similar fix in zombienet (paritytech/zombienet-sdk#481), but I think this is more accurate since the zombienet should only modify the needed keys to spawn the network.

cc: @mchristou

},
foreign_assets: ForeignAssetsConfig {
assets: vec![(
Expand Down
12 changes: 11 additions & 1 deletion cumulus/polkadot-parachain/src/chain_spec/penpal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,17 @@ pub fn staging_penpal_local_config() -> GenericChainSpec {
hex!["d47753f0cca9dd8da00c70e82ec4fc5501a69c49a5952a643d18802837c88212"]
.unchecked_into(),
],
vec![hex!["9ed7705e3c7da027ba0583a22a3212042f7e715d3c168ba14f1424e2bc111d00"].into()],
{
use sp_keyring::Sr25519Keyring;
let mut accounts = vec![hex![
"9ed7705e3c7da027ba0583a22a3212042f7e715d3c168ba14f1424e2bc111d00"
]
.into()];
// Add well-known accounts for zombienet compatibility (Alice is used for sudo
// transactions)
accounts.extend(Sr25519Keyring::well_known().map(|k| k.to_account_id()));
accounts
},
1000.into(),
))
.build()
Expand Down
Loading