rust-crypto dependency removal#85
Merged
Merged
Conversation
5 tasks
sorpaas
approved these changes
Dec 3, 2018
|
|
||
| #[cfg(test)] | ||
| #[macro_export] | ||
| macro_rules! tests_hmac { |
Contributor
There was a problem hiding this comment.
It looks like we don't need this macro now?
Also by the way, you can create a separate test file and use mod with path attribute to include it multiple times. That should make everyone's formatter much happier.
Collaborator
Author
There was a problem hiding this comment.
Thanks for the 'path' suggestion, it will be so much cleaner.
Contributor
|
Could we revive this PR? It probably needs some master merging. |
Collaborator
Author
|
no problem, will be updating that this afternoon 👍 |
tomaka
approved these changes
Apr 29, 2019
Co-Authored-By: cheme <emericchevalier.pro@gmail.com>
Contributor
|
I don't know if anyone is watching this PR. |
ordian
added a commit
that referenced
this pull request
May 6, 2019
* master: Bump fixed-hash to 0.3.2 (#134) Use EntropyRng instead of OsRng (#130) Bump parity-crypto to 0.3.1 (#132) rust-crypto dependency removal (#85) Use newly stablized TryFrom trait for primitive-types (#127) change dependencies of `keccak-hash`and `trie-standardmap` (#111) bring appveyor back (#118) Extract `should_replace` from Scoring and supply pooled txs from same sender (#116)
ordian
added a commit
that referenced
this pull request
May 6, 2019
ordian
added a commit
that referenced
this pull request
May 7, 2019
* master: uint: faster mul by u64 (#125) fix rocksdb block cache size (#122) uint: convert benchmarks to criterion (#123) Bump fixed-hash to 0.3.2 (#134) Use EntropyRng instead of OsRng (#130) Bump parity-crypto to 0.3.1 (#132) rust-crypto dependency removal (#85) Use newly stablized TryFrom trait for primitive-types (#127)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR superseed #14 , is part of #80 split. Related to #84 .
It covers 'rust-crypto' crate removal.
'RustCrypto' crate is used :
The change to ctr is probably the more impacting for parity-ethereum.
I could also adopt a conservative approach and restore old unmaintained AES rust-crypto implementation and put RustCrypto in an alternative implementation crate.
Also worth remembering that we can enable aes-ni while building with RUSTFLAGS="-C target-feature=+aes,+sse2,+ssse3", for improved performances :