change dependencies of keccak-hashand trie-standardmap#111
Merged
Conversation
|
It looks like @koushiro signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
Robbepop
reviewed
Feb 21, 2019
| #[repr(C)] | ||
| $(#[$attr])* | ||
| $visibility struct $name ([u8; $n_bytes]); | ||
| $visibility struct $name (pub [u8; $n_bytes]); |
There was a problem hiding this comment.
I think this line is already part of the other PR, isn't it?
Contributor
Author
Contributor
|
@koushiro seems like the |
Contributor
Author
Contributor
|
a rebase on master should help |
This reverts commit 529720d. Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Contributor
Author
ordian
approved these changes
Apr 2, 2019
ordian
added a commit
that referenced
this pull request
May 6, 2019
* master: Bump fixed-hash to 0.3.2 (#134) Use EntropyRng instead of OsRng (#130) Bump parity-crypto to 0.3.1 (#132) rust-crypto dependency removal (#85) Use newly stablized TryFrom trait for primitive-types (#127) change dependencies of `keccak-hash`and `trie-standardmap` (#111) bring appveyor back (#118) Extract `should_replace` from Scoring and supply pooled txs from same sender (#116)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
ethereum-typesdep toprimitive-typesdep ofkeccak-hash.Remove the
ethereum-typesdep oftrie-standardmap.Need to process the #110 firstly.