uint: convert benchmarks to criterion #123
Merged
Merged
Conversation
dvdplm
reviewed
Apr 17, 2019
Contributor
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
The Criterion docs claim it's pretty good at inserting black_box where needed, did you try to not use it explicitly like we're used to do with the libtest benchmarks? There's also a mention in the FAQ that the Criterion black_box is somewhat less reliable than the one available on nightly (and an opt-in to use that instead).
dvdplm
approved these changes
Apr 18, 2019
Merged
sorpaas
approved these changes
May 6, 2019
ordian
added a commit
that referenced
this pull request
May 6, 2019
* master: uint: convert benchmarks to criterion (#123)
ordian
added a commit
that referenced
this pull request
May 7, 2019
* master: uint: faster mul by u64 (#125) fix rocksdb block cache size (#122) uint: convert benchmarks to criterion (#123) Bump fixed-hash to 0.3.2 (#134) Use EntropyRng instead of OsRng (#130) Bump parity-crypto to 0.3.1 (#132) rust-crypto dependency removal (#85) Use newly stablized TryFrom trait for primitive-types (#127)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.