Abstract kvdb with cache#120
Closed
ordian wants to merge 44 commits into
Closed
Conversation
This reverts commit f9e431b.
* master: (284 commits) fix(serde deser): remove needless `len` check Update ci to crate removal. fix(deser): fix indexing into `str` bug Clean deprecated crate. Remove deps to hashdb, memdb, patricia-trie, keccak-hash. add uint operator benchmarks (#82) Update repo url Add issue number Fix ethereum-types tests readme: remove broken appveyor badge Update parity-crypto to ring v0.14 (#99) update impl-codec and update primitive-types (#101) primitive types new release Use TryFrom trait Use local path deps Deal with remaining merge issues update parity-codec for primitive types (#98) Update uint to 0.6 Add more conversion functions for U128 typo: duplicate features key ...
* master: Fix fixed-hash (#110) Update transaction-pool/src/error.rs tx-pool: I think I copied and pasted some spaces from somewhere tx-pool: remove more spaces tx-pool: where did those spaces come from tx-pool: make error generic over hash tx-pool: replace error-chain with vanilla error impl
* master: Fix impl-rlp for uint in primitive-types (#117)
Closed
Co-Authored-By: ordian <write@reusable.software>
dvdplm
reviewed
May 6, 2019
| } | ||
|
|
||
| pub trait TransactionHandler { | ||
| // TODO: how to avoid boxing? |
Contributor
Author
There was a problem hiding this comment.
Probably, also by fixing rust-lang/rust#51386
Contributor
There was a problem hiding this comment.
…so I guess that for the time being boxing is as good as it gets?
Contributor
Author
There was a problem hiding this comment.
I was hoping someone could with a better design, which would remove this requirement. Also I don't know how impactful this boxing is.
4 tasks
Contributor
|
@ordian is this still relevant, i.e. should still be reviewed? |
Contributor
Author
Contributor
Author
|
Let's close it for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The caching logic for kvdb is orthogonal to rocksdb and can be reused by other kvdb implementations.
Notable changes:
closeis called on the same thread asiter, it will deadlock (let _ = rwlock.read(); let _ = rwlock.write()).Box), not sure if it's possible to avoid that (see TODOs for reviewers).