Fix impl-rlp for uint in primitive-types

[koushiro]

Signed-off-by: koushiro koushiro.cqx@gmail.com

It should be like

parity-common/rlp/src/impls.rs

Lines 259 to 263 in c64e1b5

	impl_encodable_for_uint!(U256, 32);
	impl_encodable_for_uint!(U128, 16);
	impl_decodable_for_uint!(U256, 32);
	impl_decodable_for_uint!(U128, 16);

[parity-cla-bot]

It looks like @koushiro signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

[ordian]

Nice find, @koushiro!

There is also impl_uint_rlp!(U64, 1);.

I wonder whether we should fix impl_uint_rlp! macro itself, since it's confusing that it accepts size as bytes, while impl-serde and impl-codec as 8-byte words. cc @sorpaas (I believe it was first implemented in #86?) and cc @Robbepop. Also we have both ethereum feature in rlp and impl-rlp feature in primitive-types (probably for historical reasons, but maybe we can sort out what depends on what now).

[koushiro]

Nice find, @koushiro!

There is also impl_uint_rlp!(U64, 1);.

I wonder whether we should fix impl_uint_rlp! macro itself, since it's confusing that it accepts size as bytes, while impl-serde and impl-codec as 8-byte words. cc @sorpaas (I believe it was first implemented in #86?) and cc @Robbepop. Also we have both ethereum feature in rlp and impl-rlp feature in primitive-types (probably for historical reasons, but maybe we can sort out what depends on what now).

It seems that there is no U64 type in primitive-types, and I have fixed the impl_uint_rlp! macro. PTAL, @ordian .

[ordian]

LGTM, but would be nice to have tests to catch that kind of bugs.

CI failure is unrelated (travis on Windows is broken for ages, I'll open a separate PR to migrate back to appveyor).

[koushiro]

LGTM, but would be nice to have tests to catch that kind of bugs.

CI failure is unrelated (travis on Windows is broken for ages, I'll open a separate PR to migrate back to appveyor).

Maybe we could add some tests from https://github.com/chainx-org/chainx-common/blob/develop/primitive-types/src/tests.rs

[ordian]

Ok, let's merge this PR. A PR with tests is very welcome.