Skip to content

Update parity-codec version#68

Merged
andresilva merged 2 commits intomasterfrom
stas-codec-4-0
Jun 25, 2019
Merged

Update parity-codec version#68
andresilva merged 2 commits intomasterfrom
stas-codec-4-0

Conversation

@stanislav-tkach
Copy link
Copy Markdown
Contributor

@stanislav-tkach stanislav-tkach commented Jun 13, 2019 •
edited
Loading

Needed for the paritytech/substrate#2855.

@parity-cla-bot
Copy link
Copy Markdown

parity-cla-bot commented Jun 13, 2019

It looks like @DarkEld3r signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@stanislav-tkach stanislav-tkach mentioned this pull request Jun 13, 2019
Merged
@stanislav-tkach stanislav-tkach requested review from dvdplm and ordian June 13, 2019 20:24
dvdplm
dvdplm reviewed Jun 13, 2019
View reviewed changes
Copy link
Copy Markdown

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I have no experience with this code so best ask for a proper review from someone that does! :)

@stanislav-tkach stanislav-tkach requested a review from rphmeier June 13, 2019 21:06
@stanislav-tkach
Copy link
Copy Markdown
Contributor Author

stanislav-tkach commented Jun 13, 2019

@dvdplm Sorry, I added you because you reviewed the paritytech/parity-common#178 pull request. 🙃

andresilva
andresilva approved these changes Jun 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this will have to be rolled out in an upcoming "0.8" version, on which we also want to include some of the pending grandpa changes being integrated into substrate.

@stanislav-tkach
Copy link
Copy Markdown
Contributor Author

stanislav-tkach commented Jun 24, 2019

parity-codec version has been updated to 4.1.
cc @kianenigma

@andresilva
Copy link
Copy Markdown
Contributor

andresilva commented Jun 25, 2019

Since substrate is already depending on this I'd rather just merge this branch and have substrate track master (before we release finality-grandpa 0.8). This will also allow me to include these changes in #53 and have it build successfully on substrate's CI.

@andresilva andresilva merged commit f682e3d into master Jun 25, 2019
@stanislav-tkach stanislav-tkach deleted the stas-codec-4-0 branch June 25, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ordian ordian Awaiting requested review from ordian

3 more reviewers

@dvdplm dvdplm dvdplm left review comments

@andresilva andresilva andresilva approved these changes

@rphmeier rphmeier rphmeier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-pleasereview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stanislav-tkach @parity-cla-bot @andresilva @dvdplm @rphmeier