replace prospective round machinery with catch-up rounds#53
Merged
replace prospective round machinery with catch-up rounds#53
Conversation
rphmeier
changed the title
marcio-diaz
approved these changes
Mar 23, 2019
| // no need to listen on a round anymore once the estimate is finalized. | ||
| // | ||
| // we map `None` to true because | ||
| // - rounds are not backgrounded when incomplete unless we've skipped forward |
There was a problem hiding this comment.
Maybe assert this in the corresponding function.
Contributor
Author
|
for v0.8 |
3 tasks
Contributor
|
This has been integrated into substrate and should be ready for a final review now. |
rphmeier
commented
Jun 25, 2019
rphmeier
commented
Jun 25, 2019
Contributor
Author
|
Generally looks fine, but I'm worried about the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing process for catching up to the current round when behind followed these steps:
Replaces with catch-up rounds (#47). Logic for constructing and requesting catch-up rounds isn't yet implemented, but importing is done.