Conversation
dvdplm
left a comment
There was a problem hiding this comment.
LGTM but before approving I'd like to be reassured that the new versions work correctly with substrate and parity-ethereum.
|
@dvdplm Makes sense. I'm going to create pull requests to |
|
Feel free to publish beta versions of the crates as needed: |
|
@DarkEld3r I'll put this "in progress" for the time being to avoid accidental merges. :) |
|
As this is just a breaking release, because we removed the implementation for usize. I don't think that we need expensive testing in front of releasing these new versions. |
|
true if it works with latest 3.5.1, then only change is usize removal. You can do a substrate branch with patch dependencies to ensure this breaks doesn't create troubles, but as usize usage was wrong, It shouldn't add any trouble actually. |
|
Here is an almost green (I suppose Additional updates were required:
|
No description provided.