Skip to content

Update parity-codec version#178

Merged
dvdplm merged 2 commits intomasterfrom
stas-primitive-types-codec-4-0
Jun 13, 2019
Merged

Update parity-codec version#178
dvdplm merged 2 commits intomasterfrom
stas-primitive-types-codec-4-0

Conversation

@stanislav-tkach
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but before approving I'd like to be reassured that the new versions work correctly with substrate and parity-ethereum.

@stanislav-tkach
Copy link
Copy Markdown
Contributor Author

@dvdplm Makes sense. I'm going to create pull requests to substrate and parity-ethereum referencing this branch.

@dvdplm
Copy link
Copy Markdown
Contributor

dvdplm commented Jun 6, 2019

Feel free to publish beta versions of the crates as needed: version = "x.y.z.beta.1.

@dvdplm
Copy link
Copy Markdown
Contributor

dvdplm commented Jun 6, 2019

@DarkEld3r I'll put this "in progress" for the time being to avoid accidental merges. :)

@bkchr
Copy link
Copy Markdown
Member

bkchr commented Jun 6, 2019

As this is just a breaking release, because we removed the implementation for usize. I don't think that we need expensive testing in front of releasing these new versions.

@gui1117
Copy link
Copy Markdown
Contributor

gui1117 commented Jun 6, 2019

true if it works with latest 3.5.1, then only change is usize removal.

You can do a substrate branch with patch dependencies to ensure this breaks doesn't create troubles, but as usize usage was wrong, It shouldn't add any trouble actually.

@stanislav-tkach
Copy link
Copy Markdown
Contributor Author

Here is an almost green (I suppose impl_version should be updated?) pull request to substrate: paritytech/substrate#2855

Additional updates were required:

@dvdplm dvdplm merged commit 9d2de86 into master Jun 13, 2019
@dvdplm dvdplm deleted the stas-primitive-types-codec-4-0 branch June 13, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants