Reorder resolveOptions() env priority #6904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the priority of the destructed environment variables in resolveOptions() so that process.env and initialOptions.env are not overwritten by the result of loadDotEnv(). This fixes an issue where environment variables passed on the command line were overwritten by the values in the .env file. The following now works as expected: `SOME_VAR=foo npm run build`
|
DeMoorJasper
approved these changes
Sep 10, 2021
mischnic
approved these changes
Sep 11, 2021
lettertwo
added a commit
that referenced
this pull request
Sep 22, 2021
* v2: Upgrade Flow to 0.160.1 (#6964) Only use error overlay if there's a document (#6960) Don't fail when HTML tags are implied (#6752) Reorder resolveOptions() env priority (#6904) Change edge types to numbers (#6126) Bump swc (#6848) Print diagnostics for scope hoisting bailouts at verbose log level (#6918)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the priority of the destructed environment variables in
resolveOptions() so that process.env and initialOptions.env are not overwritten
by the result of loadDotEnv().
This fixes an issue where environment variables passed on the command line were
overwritten by the values in the .env file.
The following now works as expected:
SOME_VAR=foo npm run buildFixes: #6900