-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print diagnostics for scope hoisting bailouts at verbose log level #6918
Conversation
|
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
@@ -400,6 +400,7 @@ export default (new Transformer({ | |||
supports_module_workers: supportsModuleWorkers, | |||
is_library: asset.env.isLibrary, | |||
is_esm_output: asset.env.outputFormat === 'esmodule', | |||
trace_bailouts: options.logLevel === 'verbose', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it just be a concern of the reporter to decide to show these? Is there significant overhead to always including them in diagnostic objects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I benchmarked and it does make a measurable difference in perf. Also uses a bit more memory. I imagine there are a lot of these bailouts in large apps.
* v2: Upgrade Flow to 0.160.1 (#6964) Only use error overlay if there's a document (#6960) Don't fail when HTML tags are implied (#6752) Reorder resolveOptions() env priority (#6904) Change edge types to numbers (#6126) Bump swc (#6848) Print diagnostics for scope hoisting bailouts at verbose log level (#6918)
This adds diagnostics for scope hoisting bailouts when you use
--log-level verbose
. These also include links to the docs with more info. See also: parcel-bundler/website#934.Also fixed an issue where re-assigning the CommonJS
module
binding did not cause a bailout.