-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump swc #6848
Bump swc #6848
Conversation
|
Sourcemaps changed maybe? |
hmm is this bad? @DeMoorJasper |
@devongovett from the screenshots it looks like the mappings are more complete now? But the text Niklas added says the opposite, so not sure? More mappings is always better (as long as they're accurate) Looks fine to me either way, if it's less-complete we should probably file a bug report though |
Oh ok, I think I misread it as well. |
Any progress on this? |
I think I misinterpreted these results as well, the sourcemap is more accurate than before. So we'll probably only need to update the test fixtures |
Can confirm the sourcemaps were still wrong when I tried them out like two weeks ago so if this fixes them that'd be awesome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/transformers/js/core/Cargo.toml
And send for approval
Benchmark ResultsKitchen Sink ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
I've removed the babelrc from that test to unblock this (and also because that most basic sourcemap test shouldn't involve babel + swc anyway) |
* v2: Upgrade Flow to 0.160.1 (#6964) Only use error overlay if there's a document (#6960) Don't fail when HTML tags are implied (#6752) Reorder resolveOptions() env priority (#6904) Change edge types to numbers (#6126) Bump swc (#6848) Print diagnostics for scope hoisting bailouts at verbose log level (#6918)
Closes #6802
Closes #6765
Closes #6766
Closes #6719
Closes #6928