Closed
Conversation
clabby
commented
Nov 18, 2023
| gas: Gas::new(0), | ||
| output: Bytes::new(), | ||
| }, | ||
| 0..0, |
Collaborator
Author
There was a problem hiding this comment.
@rakita What does this new range in the result here signify? Tests are passing, though I don't think this is correct. Occurs in several places.
Collaborator
There was a problem hiding this comment.
If you want to shortcircuit the call you can return the result. So this should be None
Collaborator
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Closed
rakita
reviewed
Nov 20, 2023
| output: Bytes::new(), | ||
| }, | ||
| None, | ||
| )) |
Collaborator
There was a problem hiding this comment.
Same here, it should be None as in here: https://github.com/paradigmxyz/reth/pull/5489/files/880fd26ca13093810afc7f6d2e1e9617b44c0ecb#r1398242606
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Upgrades
revmto the latest version, which includes theCanyonhardfork. This unblocks implementing theCanyonhardfork forop-reth, tracked in #5210.Metadata
Closes #5490