feat: Canyon hardfork behind optimism feature flag#871
Merged
rakita merged 2 commits intobluealloy:mainfrom Nov 20, 2023
Merged
feat: Canyon hardfork behind optimism feature flag#871rakita merged 2 commits intobluealloy:mainfrom
Canyon hardfork behind optimism feature flag#871rakita merged 2 commits intobluealloy:mainfrom
Conversation
This was referenced Nov 18, 2023
rakita
reviewed
Nov 20, 2023
| } | ||
| } | ||
| #[cfg(feature = "optimism")] | ||
| define_spec_id!( |
Member
There was a problem hiding this comment.
I like the idea of having a separate SpecId structure, but it isn't best to wrap it inside macro.
You could do:
/// Specification IDs and their activation block.
///
/// See: [Ethereum Execution Specs](https://github.com/ethereum/execution-specs)
#[cfg(feature = "optimism")]
#[repr(u8)]
#[derive(Debug, Copy, Clone, PartialEq, Eq, Hash, Ord, PartialOrd, enumn::N)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub enum SpecId {
...
}
3f83583 to
5b30bb0
Compare
5b30bb0 to
a9f94be
Compare
rakita
pushed a commit
that referenced
this pull request
Nov 21, 2023
* Add `Canyon` hardfork behind `optimism` feature flag * Remove macro
rakita
pushed a commit
that referenced
this pull request
Nov 21, 2023
* Add `Canyon` hardfork behind `optimism` feature flag * Remove macro
Member
|
Just to note here, I created this change on the top of the 1609e07 commit. This "parent" commit is used inside reth and the idea is to freeze revm as there are some breaking revm changes so it would be less painful. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds the
Canyonhardfork behind theoptimismfeature flag, and adds a macro to define theSpecIdenum to separate the ordering of hardforks between L1 andoptimism.The
Canyonhardfork does not implement any EVM changes, though it does implicitly enableShanghai.More information about
Canyoncan be found in the upstream tracking issue: ethereum-optimism/optimism#7452