Closed
Conversation
This was referenced Nov 20, 2023
mattsse
requested changes
Nov 20, 2023
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
need to check, new revm api.
in the meantime please remove trailing ;
| context: &mut EvmContext<'_, DB>, | ||
| inputs: &mut CallInputs, | ||
| ) -> (InstructionResult, Gas, Bytes) { | ||
| ) -> Option<(InterpreterResult, Range<usize>)> { |
Collaborator
Author
There was a problem hiding this comment.
Yeah I'm not convinced the ranges being passed are correct, just 0..0 atm to placehold... Need to read into what it signifies
Collaborator
There was a problem hiding this comment.
Return struct should definitely be added, Range represents output place to the memory (where to write it).
Option is there if we want to short circuit the call and immediately return.
I talked with @mattsse and I feel that a better solution is to freeze revm version inside reth, and just cherry-pick needed commits. This would skip this additional work on integration of breaking changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Upgrades
revmto the head commit (as of Nov 20, 2023), which includes theCanyonhardfork definition.Metadata
closes #5490