fix(payload): Ethereum Payload Builder Zero Type#5313
Merged
mattsse merged 9 commits intoparadigmxyz:mainfrom Nov 6, 2023
Merged
fix(payload): Ethereum Payload Builder Zero Type#5313mattsse merged 9 commits intoparadigmxyz:mainfrom
mattsse merged 9 commits intoparadigmxyz:mainfrom
Conversation
refcell
changed the title
mattsse
requested changes
Nov 5, 2023
mattsse
reviewed
Nov 5, 2023
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
the default usage also needs to be updated:
reth/crates/payload/basic/src/lib.rs
Line 67 in 3d076b1
refcell
changed the title
refcell
changed the title
mattsse
approved these changes
Nov 6, 2023
mattsse
added a commit
that referenced
this pull request
Nov 8, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Defines an
EthereumPayloadBuildertype as the empty tuple type following @gakonst's comment in #4377 (comment)