Skip to content

fix(payload): Ethereum Payload Builder Zero Type #5313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 9 commits into from
Nov 6, 2023
Merged

fix(payload): Ethereum Payload Builder Zero Type #5313

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
398564c
define empty tuple type as ethereum payload builder
refcell Nov 5, 2023
fb22f4d
struct -> type
refcell Nov 5, 2023
6d10438
struct + doc comments
refcell Nov 5, 2023
deecc4e
fix default ethereum payload builder
refcell Nov 5, 2023
a2d2d6d
inplace default builder fixes
refcell Nov 5, 2023
7980cb3
impl EthereumPayloadBuilder
refcell Nov 5, 2023
068f295
fix formatting
refcell Nov 5, 2023
2b79fab
remove non exhaustive
refcell Nov 5, 2023
8e54a7f
touchups
mattsse Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/reth/src/cli/ext.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ pub trait RethNodeCommandConfig: fmt::Debug {
// The default payload builder is implemented on the unit type.
#[cfg(not(feature = "optimism"))]
#[allow(clippy::let_unit_value)]
let payload_builder = ();
let payload_builder = reth_basic_payload_builder::EthereumPayloadBuilder;

// Optimism's payload builder is implemented on the OptimismPayloadBuilder type.
#[cfg(feature = "optimism")]
Expand Down
3 changes: 3 additions & 0 deletions crates/payload/basic/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ use tracing::{debug, trace};

mod metrics;

#[cfg(not(feature = "optimism"))]
Comment thread
refcell marked this conversation as resolved.
Outdated
pub type EthereumPayloadBuilder = ();
Comment thread
refcell marked this conversation as resolved.
Outdated

#[cfg(feature = "optimism")]
mod optimism;
#[cfg(feature = "optimism")]
Expand Down