Skip to content

feat: op-reth#4377

Merged
rkrasiuk merged 460 commits intoparadigmxyz:mainfrom
op-rs:clabby/op-reth
Nov 5, 2023
Merged

feat: op-reth#4377
rkrasiuk merged 460 commits intoparadigmxyz:mainfrom
op-rs:clabby/op-reth

Conversation

@clabby
Copy link
Collaborator

@clabby clabby commented Aug 28, 2023

Overview

This PR contains the full diff for op-reth.

Note: 29,725 lines of this diff consists of large genesis files for base goerli and base mainnet.

Resources

All Future Issues (tracking)

op-geth mappings

The below toggles contain mappings of all op-geth diff changes to their respective places in op-reth.

(if you have questions on this stuff ask @refcell - wrote all these toggles out)

op-geth Diff Mapping: Core Modifications +901 | -52
op-geth Diff Mapping: Node modifications +158 | -10
op-geth Diff Mapping: User API enhancements +995 | -63
op-geth Diff Mapping: Geth extras (not mapped 1:1 since we will have "reth extras") +325 | -25
op-geth Diff Mapping: Other changes +690 | -16

@refcell refcell mentioned this pull request Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #4377 (71836cd) into main (4dc15c3) will increase coverage by 21.63%.
Report is 93 commits behind head on main.
The diff coverage is 49.53%.

❗ Current head 71836cd differs from pull request most recent head 62f8111. Consider uploading reports for the commit 62f8111 to get more accurate results

Impacted file tree graph

Files Coverage Δ
bin/reth/src/args/utils.rs 69.04% <100.00%> (+52.60%) ⬆️
bin/reth/src/cli/config.rs 0.00% <ø> (-100.00%) ⬇️
bin/reth/src/init.rs 91.05% <100.00%> (+42.69%) ⬆️
crates/interfaces/src/executor.rs 20.00% <ø> (+20.00%) ⬆️
crates/net/network-api/src/lib.rs 65.00% <ø> (ø)
crates/net/network-api/src/noop.rs 66.66% <100.00%> (-4.77%) ⬇️
crates/net/network/src/manager.rs 45.91% <100.00%> (-9.68%) ⬇️
crates/net/network/src/test_utils/testnet.rs 81.21% <ø> (-6.37%) ⬇️
crates/payload/builder/src/error.rs 0.00% <ø> (ø)
crates/primitives/src/basefee.rs 99.11% <100.00%> (+68.92%) ⬆️
... and 56 more

... and 390 files with indirect coverage changes

Flag Coverage Δ
integration-tests 14.18% <5.69%> (-11.89%) ⬇️
unit-tests 41.06% <45.17%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 21.34% <17.72%> (-4.44%) ⬇️
blockchain tree 32.12% <ø> (+3.66%) ⬆️
pipeline 66.24% <ø> (+61.19%) ⬆️
storage (db) 52.38% <0.00%> (+22.40%) ⬆️
trie 52.18% <ø> (+29.65%) ⬆️
txpool 40.12% <79.20%> (-1.26%) ⬇️
networking 55.14% <62.96%> (+24.24%) ⬆️
rpc 40.33% <5.55%> (+13.85%) ⬆️
consensus 42.51% <32.43%> (+17.45%) ⬆️
revm 21.07% <74.55%> (+11.22%) ⬆️
payload builder 6.10% <0.00%> (-8.06%) ⬇️
primitives 64.78% <66.50%> (+35.61%) ⬆️

Copy link
Contributor

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving first round of comments

@rkrasiuk rkrasiuk added the A-op-reth Related to Optimism and op-reth label Aug 28, 2023
@ghost
Copy link

ghost commented Nov 5, 2023

Further, not supporting historical (pre-bedrock) rpc daisy chaining doesn't prevent a mainnet bedrock node from syncing and following tip successfully.

@refcell Yes, have you tested or are you testing it now? Due to the receipt RPC fixed for reth #5084 I think it is now possible to sync from op-node at the faster speed

refcell and others added 2 commits November 5, 2023 12:51
…tiation

fix(rpc): Move reqwest client into EthApiInner
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine now,
needs followups for things discussed separately.

would appreciate if @DaniPopes could take a look at the CI changes before we send it

@mattsse mattsse requested a review from DaniPopes November 5, 2023 13:19
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@rkrasiuk rkrasiuk added this pull request to the merge queue Nov 5, 2023
Merged via the queue into paradigmxyz:main with commit 52670a8 Nov 5, 2023
mattsse pushed a commit that referenced this pull request Nov 8, 2023
Co-authored-by: Roberto Bayardo <bayardo@alum.mit.edu>
Co-authored-by: refcell.eth <abigger87@gmail.com>
Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com>
Co-authored-by: refcell <refcell@oplabs.co>
Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com>
@emhane emhane deleted the clabby/op-reth branch September 25, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-op-reth Related to Optimism and op-reth

Projects

None yet

Development

Successfully merging this pull request may close these issues.